PKCS #8 Private-Key Information Content Types
draft-ietf-lamps-pkcs8-prikeyinfo-contenttypes-04

# Andy Newton, ART AD, comments for draft-ietf-lamps-pkcs8-prikeyinfo-contenttypes-01
CC @anewton1998

* line numbers:
  - https://author-tools.ietf.org/api/idnits?url=https://www.ietf.org/archive/id/draft-ietf-lamps-pkcs8-prikeyinfo-contenttypes-01.txt&submitcheck=True

* comment syntax:
  - https://github.com/mnot/ietf-comments/blob/main/format.md

* "Handling Ballot Positions":
  - https://ietf.org/about/groups/iesg/statements/handling-ballot-positions/

I have no objection to the publication of this document.

Many thanks to Gonzalo Salgueiro for the ARTART review.

Thanks for the work is described in this document. 

I do not see any transport-related concerns for this I-D. But, I would really appreciate more description about what is intended and why in the introduction.

Hi Joe, Russ, and Sean,

Thanks for the effort put into this specification. 

Please find some comments below: 

# Lack of motivation 

Consider adding one or two sentences early in the document to explain what problem the new types solve.  

# ASN.1 normative references

Shouldn’t at least X.680 be provided as normative reference for the module?

# Section 6

Is that intended to be an appendix? If so, tag it as such.

Cheers,
Med

# Orie Steele, ART AD, comments for draft-ietf-lamps-pkcs8-prikeyinfo-contenttypes-01 
CC @OR13

* line numbers:
  - https://author-tools.ietf.org/api/idnits?url=https://www.ietf.org/archive/id/draft-ietf-lamps-pkcs8-prikeyinfo-contenttypes-01.txt&submitcheck=True

* comment syntax:
  - https://github.com/mnot/ietf-comments/blob/main/format.md

* "Handling Ballot Positions":
  - https://ietf.org/about/groups/iesg/statements/handling-ballot-positions/

Thank you to Gonzalo Salgueiro for the ARTART review.

## Comments

### Media types

```
81	   The syntax for private-key information was originally described in
82	   [RFC5208] and later obsoleted by [RFC5958].  This document defines
83	   PKCS #8 content types for use with PrivateKeyInfo and
84	   EncryptedPrivateKeyInfo.
```

See RFC 2046 for the history of MIME / media types.

Consider: 
https://www.iana.org/assignments/media-types/application/pkcs8

Based on the abstract, I was expecting to see media types here, but it seems content types have a specific meaning in the context of lamps.

Am I correct to assume that "application/pkcs8" can carry both PrivateKeyInfo and EncryptedPrivateKeyInfo?

A sentence relating these oids to the existing registered media types might be helpful.

Thank you to Vijay Gurbani for the GENART review.

** Section 6
6.  ASN.1 Module

   The ASN.1 module in this section builds upon the modules in
   [RFC5911].

Please add a normative reference to for ASN.1.  It is cited in RFC5911 (which is a normative reference) but should also be done here.  Perhaps:

[ASN1-2002]  ITU-T, "ITU-T Recommendation X.680, X.681, X.682, and
X.683", ITU-T X.680, X.681, X.682, and X.683, 2002.

Thanks for the work done in this document even if the introduction/justification is weird and too concise.

The shepherd's write-up does not include any justification of the intended status.

As indicated by the idnits tool, section 2 (the BCP14 template) MUST be removed as it is not used.

It usually helps to add an informational reference to the registry URI.