A YANG Data Model for Augmenting VPN Service and Network Models with Attachment Circuits
draft-ietf-opsawg-ac-lxsm-lxnm-glue-14

Thanks to Prachi Jain for the secdir review.

# Gunter Van de Velde, RTG AD, comments for draft-ietf-opsawg-ac-lxsm-lxnm-glue-13

# the referenced line numbers are derived from the idnits tool:
https://author-tools.ietf.org/api/idnits?url=https://www.ietf.org/archive/id/draft-ietf-opsawg-ac-lxsm-lxnm-glue-13.txt

# This is a well written document. I have few non-blocking editorial comments

#DETAILED COMMENTS
#=================

18	   The document specifies a module that updates existing service (i.e.,
19	   the Layer 2 Service Model (L2SM) and the Layer 3 Service Model
20	   (L3SM)) and network (i.e., the Layer 2 Network Model (L2NM) and the
21	   Layer 3 Network Model (L3NM)) Virtual Private Network (VPN) modules
22	   with the required information to bind specific VPN services to
23	   attachment circuits (ACs) that are created using the AC service
24	   ("ietf-ac-svc") and network ("ietf-ac-ntw") models.

GV> While correct, I did find this abstract not so easy to digest and i saw no correlation with the proposed "AC-glue" model. What about the following alterative. Maybe 

"
This document defines a YANG data model, referred to as the “AC-Glue” model, to 
augment the LxSM and LxNM with references to Attachment Circuits (ACs). The AC-Glue 
model enables a provider to associate configured Layer 2 and Layer 3 VPN services (LxVPN) 
with the underlying AC infrastructure, thereby facilitating consistent provisioning and 
management of new or existing ACs in conjunction with LxVPN services. By introducing an 
integrated approach to AC and LxVPN management, this model supports an Attachment 
Circuit-as-a-Service (ACaaS) paradigm and provides a standardized mechanism for 
aligning AC requests with the network configurations required to deliver them.
"


166	   ac:  Attachment circuit

GV> sometimes the AC is upper case (e.g. AC-glue, etc) and sometimes lower case (i.e. ac-ntw-ref, etc). Is this intetional?

Many thanks again for this document,

Kind Regards,
Gunter Van de Velde,
RTG AD

A few outdated references but other than that no substantive comments:

  == Outdated reference: A later version (-15) exists of
     draft-ietf-opsawg-ntw-attachment-circuit-14

  == Outdated reference: A later version (-19) exists of
     draft-ietf-opsawg-teas-attachment-circuit-18

  == Outdated reference: A later version (-22) exists of
     draft-ietf-netmod-rfc8407bis-21

  == Outdated reference: A later version (-14) exists of
     draft-ietf-opsawg-teas-common-ac-13

Thank you to Reese Enghardt for the GENART review.

Thank you to Ron Bonica for their OpsDir review: https://datatracker.ietf.org/doc/review-ietf-opsawg-ac-lxsm-lxnm-glue-10-opsdir-lc-bonica-2024-07-06/