Last Call Review of draft-ietf-bess-nsh-bgp-control-plane-13
review-ietf-bess-nsh-bgp-control-plane-13-opsdir-lc-jiang-2019-12-16-00

Request Review of draft-ietf-bess-nsh-bgp-control-plane
Requested rev. no specific revision (document currently at 18)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2019-12-13
Requested 2019-11-29
Authors Adrian Farrel, John Drake, Eric Rosen, Jim Uttaro, Luay Jalil
Draft last updated 2019-12-16
Completed reviews Rtgdir Last Call review of -13 by Ravi Singh (diff)
Tsvart Last Call review of -13 by Olivier Bonaventure (diff)
Opsdir Last Call review of -13 by Sheng Jiang (diff)
Secdir Last Call review of -13 by Scott Kelly (diff)
Genart Last Call review of -12 by Brian Carpenter (diff)
Assignment Reviewer Sheng Jiang 
State Completed
Review review-ietf-bess-nsh-bgp-control-plane-13-opsdir-lc-jiang-2019-12-16
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/DSx1pRvaZNg9xsfboY451hiyM0c
Reviewed rev. 13 (document currently at 18)
Review result Has Issues
Review completed: 2019-12-16

Review
review-ietf-bess-nsh-bgp-control-plane-13-opsdir-lc-jiang-2019-12-16

Reviewer: Sheng Jiang
Review result: Has Issues

Reviewer: Sheng Jiang
Review result: Has Issues

Hi, OPS-DIR, Authors,

I have reviewed this document as part of the Operational directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written with the intent of improving the operational aspects of the IETF drafts. Comments that are not addressed in last call may be included in AD reviews during the IESG review. Document editors and WG chairs should treat these comments just like any other last call comments.

This standard track document describes the use of BGP as a control plane for networks that support SFC with newly defined BGP Parameters, BGP AF/SAF, BGP Path Attribute , SFP Attribute TLVs Type Registry, SFP Association Type Registry and Service Function Type Registry.

This document is clear and well written. 

Minor issues:

However, I do have an issue with the terminology controller in this document. Although the community seems knowing the SDN controller concepts well. There is no well-defined terminology for it. Therefore, this document are missing the most fundamental reference. The below three RFCs are potential references for the terminology, but still not the best suitable one, and they are all Informational RFCs, which is Downref in this context: 

RFC 7426: Software-Defined Networking (SDN): Layers and Architecture Terminology
RFC 8455: Terminology for Benchmarking Software-Defined Networking (SDN) Controller Performance
RFC 8456: Benchmarking Methodology for Software-Defined Networking (SDN) Controller Performance

And this document has already had two Downref RFC 7665, RFC 8596