Last Call Review of draft-ietf-curdle-cms-ecdh-new-curves-07
review-ietf-curdle-cms-ecdh-new-curves-07-opsdir-lc-winter-2017-05-23-00

Request Review of draft-ietf-curdle-cms-ecdh-new-curves
Requested rev. no specific revision (document currently at 10)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2017-05-28
Requested 2017-05-14
Other Reviews Secdir Last Call review of -07 by Charlie Kaufman (diff)
Genart Last Call review of -07 by Roni Even (diff)
Genart Telechat review of -09 by Roni Even (diff)
Review State Completed
Reviewer Stefan Winter
Review review-ietf-curdle-cms-ecdh-new-curves-07-opsdir-lc-winter-2017-05-23
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/16_x3UDnQpGM60VK3YDqUrH_CXE
Reviewed rev. 07 (document currently at 10)
Review result Has Nits
Draft last updated 2017-05-23
Review completed: 2017-05-23

Review
review-ietf-curdle-cms-ecdh-new-curves-07-opsdir-lc-winter-2017-05-23

Nits: 

* 2.1 starts with "...  based on a one-way hash function described in ANS X9.63 [X963]." s/ANS/ANSI/

* Chapter 7 defines six OIDs (secg-scheme 11 1...3 and smime-alg TBD1...3) and also includes the base OIDs under which these new OIDs are attached (secg-scheme and smime-alg). Those two are not defined in this document, but the text in chapter 7 suggests so.
Maybe it would be a bit clearer if the text stated explicitly which of the OIDs in the chapter are NEW, and which ones already exist and are provided for reference/context.