Skip to main content

Telechat Review of draft-ietf-emu-rfc7170bis-16
review-ietf-emu-rfc7170bis-16-intdir-telechat-song-2024-05-10-00

Request Review of draft-ietf-emu-rfc7170bis
Requested revision No specific revision (document currently at 22)
Type Telechat Review
Team Internet Area Directorate (intdir)
Deadline 2024-05-21
Requested 2024-05-01
Requested by Éric Vyncke
Authors Alan DeKok
I-D last updated 2026-01-09 (Latest revision 2025-05-28)
Completed reviews Dnsdir Telechat review of -16 by Ralf Weber (diff)
Intdir Telechat review of -16 by Haoyu Song (diff)
Dnsdir Telechat review of -17 by Ralf Weber (diff)
Dnsdir IETF Last Call review of -15 by Ralf Weber (diff)
Opsdir IETF Last Call review of -15 by Bo Wu (diff)
Secdir IETF Last Call review of -15 by David Mandelberg (diff)
Assignment Reviewer Haoyu Song
State Completed
Request Telechat review on draft-ietf-emu-rfc7170bis by Internet Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/int-dir/jyDarBq2Vl4ozTCkDb-9SaBSLRs
Reviewed revision 16 (document currently at 22)
Result Ready w/nits
Completed 2024-05-10
review-ietf-emu-rfc7170bis-16-intdir-telechat-song-2024-05-10-00
I’m the assigned INTDIR reviewer for this document. This document defines the
Tunnel Extensible Authentication Protocol V1 which obsoletes RFC7010.

I couldn’t find any technical issues, but some nits as listed below.

Please spell out the acronyms in the first use, e.g., PKCS

Pg13 “In some cases such as onboarding …”.  It may be necessary to elaborate
the terms used here.

Pg14  “It will therefore no way of correlating the server identity…”  Grammer
check

Pg18 “MUST accompany the TLV with it's own Crypto-Binding TLV”     it’s own ->
its own

Pg18 “to communicate a users password,”   users -> user’s

Pg 20.  “EAP- FAST [RFC4851]”   remove the space after EAP-

Pg 22. “it requires a particular authentication mechanism be run”  be run -> to
be run

Pg. 24 “in all phases of TEAP’  all -> both?

Pg27. “The device authentications, and obtains new credentials via” 
authentications, -> authenticates

Pg31. “If the server didn't initiate …”   didn’t -> did not

Pg 34. “If all TLVs in a message are marked optional and none are understood by
the peer, then a NAK TLV or Result TLV could be sent to the other side in order
to continue the conversation.” The two sentences seem logically conflicting
with each other.

Pg38. “The behavior of the Result TLV is further discussed in Section 3.6.5 and
Section 3.9.3 A Result” missing period before A Result.

Pg.46. “after one or more of the requested items has been processed …”   has ->
have

Pg 60. “The Identity-Hint TLV is an optional TLV which can sent by the peer” 
can sent -> can be sent

Pg 60. “the format and definition of these identities is entirely site local.” 
 is -> are

Pg 64. “Note that using a MSK…” a -> an

Thanks,
Haoyu