Last Call Review of draft-ietf-httpbis-binary-message-04
review-ietf-httpbis-binary-message-04-artart-lc-gruessing-2022-05-30-00
| Request | Review of | draft-ietf-httpbis-binary-message |
|---|---|---|
| Requested revision | No specific revision (document currently at 06) | |
| Type | IETF Last Call Review | |
| Team | ART Area Review Team (artart) | |
| Deadline | 2022-06-03 | |
| Requested | 2022-05-20 | |
| Authors | Martin Thomson , Christopher A. Wood | |
| I-D last updated | 2022-08-30 (Latest revision 2022-07-06) | |
| Completed reviews |
Genart IETF Last Call review of -04
by David Schinazi
(diff)
Artart IETF Last Call review of -04 by James Gruessing (diff) Secdir IETF Last Call review of -04 by Daniel Migault (diff) |
|
| Assignment | Reviewer | James Gruessing |
| State | Completed | |
| Request | IETF Last Call review on draft-ietf-httpbis-binary-message by ART Area Review Team Assigned | |
| Posted at | https://mailarchive.ietf.org/arch/msg/art/UTGaEWDXHSFP8RokAwXT3h7XCgg | |
| Reviewed revision | 04 (document currently at 06) | |
| Result | Ready | |
| Completed | 2022-05-30 |
review-ietf-httpbis-binary-message-04-artart-lc-gruessing-2022-05-30-00
This is my review of draft-ietf-httpbis-binary-message-04 as part of ART Last Call review. Overall this is a concisely written document, and although the specification makes it clear that its format is distinct from existing framing defined within HTTP/2 and HTTP/3 (in addition to borrowing elements from QUIC) readers who are not already familiar with these may be at a considerable disadvantage trying to understand this document. Editorial Comments: Section 3 is quite difficult to grok, and I agree with the suggestions made by David Schinazi in his Gen-ART review. However as one additional minor suggestion is that references to section 4 within section 3 appear repetitiously, and as section 4 doesn't provide specific guidance for each of the invalid message scenarios but generic text I'd suggest you include "invalid message" as a definition in section 2 that states all usage of the word is applicable to section 4. Section 6 - As a suggestion I would propose the normative text around pseudo-fields instead be placed within appropriate sub-sections of section 3, keeping section 6 exclusively informative. Asides from this there are no further nits or major issues to mention.