Skip to main content

Early Review of draft-ietf-ippm-on-path-telemetry-yang-00
review-ietf-ippm-on-path-telemetry-yang-00-yangdoctors-early-bjorklund-2025-06-17-00

Request Review of draft-ietf-ippm-on-path-telemetry-yang
Requested revision No specific revision (document currently at 02)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2025-06-30
Requested 2025-06-02
Requested by Thomas Graf
Authors Giuseppe Fioccola , Tianran Zhou , Yongqing Zhu , Wenqiang Zhang , Keyi Zhu
I-D last updated 2026-01-02 (Latest revision 2026-01-02)
Completed reviews Yangdoctors Early review of -00 by Martin Björklund (diff)
Comments
IPPM received during the adoption call feedback on the mailing list https://mailarchive.ietf.org/arch/msg/ippm/KPxAiJfHakbeIOubHWXbRonZPzo/ that NMDA objectives https://datatracker.ietf.org/doc/html/rfc8342#section-2, having the operational and configurational state in the same data tree, are not met by the document.

We request therefore a early review by the YANG doctors to understand in which direction the document should go from a YANG doctors perspective. Remain as separate YANG module or augment existing models ietf-ioam resp. ietf-altmark YANG modules.
Assignment Reviewer Martin Björklund
State Completed
Request Early review on draft-ietf-ippm-on-path-telemetry-yang by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/-ne1DwpDDCsSLDwINig84oC8bYg
Reviewed revision 00 (document currently at 02)
Result Not ready
Completed 2025-06-17
review-ietf-ippm-on-path-telemetry-yang-00-yangdoctors-early-bjorklund-2025-06-17-00
Here is my early YANG doctors review of
draft-ietf-ippm-on-path-telemetry-yang-00.

There are some major issues that make it difficult to understand how this model
is supposed to be used.  I will do a more detailed review once these are
addressed.

First of all, the included tree diagram says that all nodes are config false,
but in the data model all nodes are config true.  (also, the names of the nodes
in the tree diagram don't match the module in many cases). What is the
intention?  Should all nodes be config false?   Including filters and node
actions?   The Security Considerations section seems to indicate that at least
some nodes are config true.

There is a global leaf "timestamp" which is described in the text as "the
timestamp of the message".  How can a global leaf contain a timestamp of "the
message"?

Most description statements contain basically no information.  For example:

       leaf direct-export-data {
          type ioam-trace-data;
          description
            "This object indicates the direct export data.";
       }

I suggest you expand the descriptions, and add references where applicable.

Finally I suggest you add some examples in an appendix that show how this model
can be used.

/martin