Skip to main content

Last Call Review of draft-ietf-jsonpath-base-16
review-ietf-jsonpath-base-16-artart-lc-miller-2023-08-07-00

Request Review of draft-ietf-jsonpath-base
Requested revision No specific revision (document currently at 21)
Type Last Call Review
Team ART Area Review Team (artart)
Deadline 2023-08-09
Requested 2023-07-26
Authors Stefan Gössner , Glyn Normington , Carsten Bormann
I-D last updated 2023-08-07
Completed reviews Secdir Last Call review of -17 by Dan Harkins (diff)
Artart Last Call review of -16 by Darrel Miller (diff)
Genart Last Call review of -17 by Linda Dunbar (diff)
Opsdir Last Call review of -16 by Joe Clarke (diff)
Assignment Reviewer Darrel Miller
State Completed
Request Last Call review on draft-ietf-jsonpath-base by ART Area Review Team Assigned
Posted at https://mailarchive.ietf.org/arch/msg/art/8V89pDYVPmgGlKBTesaaWv-N86A
Reviewed revision 16 (document currently at 21)
Result Ready
Completed 2023-08-07
review-ietf-jsonpath-base-16-artart-lc-miller-2023-08-07-00
I was asked to review this document for the ART area.  As a frequent user of
JSON in HTTP APIs, and related specifications I am delighted to see this
document reaching last call.

I think the word that sums up this document the best is "comprehensive". From
the clearly defined terminology at the beginning of the document, examples
included at every step of the way, clear separation of syntax and semantics of
each concept introduced and the detailed treatment of the type system around
functions, I found this document answered every question I might possibly have.

The only nit that I have is that the ABNF rule S is first used in section 2.1.1
and points to section 2.5 for details.  However, if you go to section 2.5 it
does not define S because it was already defined in section 2.3.4.1.  It might
be nice to have an appendix with a "collected" ABNF like RFC9110 does, so that
any rule is easy to find.