Early Review of draft-ietf-lime-yang-oam-model-10
review-ietf-lime-yang-oam-model-10-yangdoctors-early-moberg-2017-06-02-00
Request | Review of | draft-ietf-lime-yang-oam-model-08 |
---|---|---|
Requested revision | 08 (document currently at 10) | |
Type | Early Review | |
Team | YANG Doctors (yangdoctors) | |
Deadline | 2017-02-28 | |
Requested | 2017-02-07 | |
Requested by | Mehmet Ersue | |
Authors | Deepak Kumar , Qin Wu , Zitao Wang | |
I-D last updated | 2017-06-02 | |
Completed reviews |
Yangdoctors Early review of -10
by Carl Moberg
|
|
Assignment | Reviewer | Carl Moberg |
State | Completed | |
Request | Early review on draft-ietf-lime-yang-oam-model by YANG Doctors Assigned | |
Reviewed revision | 10 | |
Result | On the Right Track | |
Completed | 2017-06-02 |
review-ietf-lime-yang-oam-model-10-yangdoctors-early-moberg-2017-06-02-00
I am the assigned YANG Doctor for the LIME YANG modules, this is the notes from my initial review of draft-ietf-lime-yang-oam-model done with the authors: First of all, would suggest we rename draft and the module itself: OLD: draft-ietf-lime-yang-oam-model NEW: draft-ietf-lime-yang-connection-oriented-oam-model OLD: ietf-conn-oam NEW: ietf-connection-oriented-oam There are several uses of 'ordered-by system;'. Unless there is a specific, and documented reason for pointing out this default behavior, I suggest we simply remove them entirely. Please review the use of case, e.g. the 'Interval' typedef should likely be all lowercase. The description fields will need some language editing before release, e.g. the "Indicate whether the CC enable." description string for the 'MEP' list.