Skip to main content

Last Call Review of draft-ietf-manet-dlep-da-credit-extension-18
review-ietf-manet-dlep-da-credit-extension-18-opsdir-lc-fioccola-2024-08-02-01

Request Review of draft-ietf-manet-dlep-da-credit-extension
Requested revision No specific revision (document currently at 20)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2024-08-13
Requested 2024-07-23
Requested by Jim Guichard
Authors Bow-Nan Cheng , David Wiggins , Lou Berger , Donald E. Eastlake 3rd
I-D last updated 2024-08-02
Completed reviews Tsvart Early review of -12 by David L. Black (diff)
Rtgdir Last Call review of -18 by He Jia (diff)
Secdir Last Call review of -18 by Joseph A. Salowey (diff)
Genart Last Call review of -17 by Paul Kyzivat (diff)
Opsdir Last Call review of -18 by Giuseppe Fioccola (diff)
Rtgdir Last Call review of -18 by Zheng Zhang (diff)
Assignment Reviewer Giuseppe Fioccola
State Completed
Request Last Call review on draft-ietf-manet-dlep-da-credit-extension by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/tBYS7rHMDxAsedhyJvuba2NZ8nw
Reviewed revision 18 (document currently at 20)
Result Ready
Completed 2024-08-02
review-ietf-manet-dlep-da-credit-extension-18-opsdir-lc-fioccola-2024-08-02-01
This document is well written and clear for its scope.

This I-D, together with draft-ietf-manet-dlep-credit-flow-control and
draft-ietf-manet-dlep-traffic-classification, specify a DiffServ-aware credit
window based flow control scheme as a new extension to DLEP (RFC 8175).

From an OPSDIR point of view, the document includes a dedicated section on
Management Considerations. Since I also looked at the companions
draft-ietf-manet-dlep-credit-flow-control and
draft-ietf-manet-dlep-traffic-classification, I think that some details about
the implementation can be provided. It would be good to mention or give
examples on how the different parameters can be configured and how the
information can possibly be exported. This suggestion mainly applies to the
companion documents, which are normative references for this I-D.

As an editorial comment for this I-D, you can consider to include a figure with
the Extension Data Item or you can simply add a reference to section 13.6 of
RFC 8175 somewhere.