Last Call Review of draft-ietf-pce-association-policy-15
review-ietf-pce-association-policy-15-secdir-lc-kelly-2021-01-05-00

Request Review of draft-ietf-pce-association-policy
Requested rev. no specific revision (document currently at 15)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2020-12-24
Requested 2020-12-10
Authors Stephane Litkowski, Siva Sivabalan, Jeff Tantsura, Jonathan Hardwick, Cheng Li
Draft last updated 2021-01-05
Completed reviews Rtgdir Last Call review of -13 by Nicolai Leymann (diff)
Secdir Last Call review of -15 by Scott Kelly
Genart Last Call review of -15 by Vijay Gurbani
Assignment Reviewer Scott Kelly 
State Completed
Review review-ietf-pce-association-policy-15-secdir-lc-kelly-2021-01-05
Posted at https://mailarchive.ietf.org/arch/msg/secdir/1zlTuu8MP29I9w7D003_cDPxFaM
Reviewed rev. 15
Review result Ready
Review completed: 2020-12-31

Review
review-ietf-pce-association-policy-15-secdir-lc-kelly-2021-01-05

I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written primarily for the benefit of the security area directors.  Document editors and WG chairs should treat these comments just like any other last call comments.

The summary of the review is ready.

From the abstract, this document introduces a simple mechanism to associate policies to a group of Label Switched Paths (LSPs) via an extension to the Path Computation Element (PCE) Communication Protocol (PCEP).

The security considerations section references security considerations from RFCs 5394, 5440, 8231, 8281, 8408, and 8697. In addition, it recommends securing sessions with TLS in accordance with RFCs 8253 and 7525.

Because this protocol extension utilizes TLVs, there is an explicit call for care in decoding and utilizing these TLVs due to the potential for attack via malformed payloads.

I'm not a routing expert, but I think the authors have adequately covered security considerations for this extension.