Last Call Review of draft-vandevenne-shared-brotli-format-11
review-vandevenne-shared-brotli-format-11-genart-lc-bryant-2024-10-01-00

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-vandevenne-shared-brotli-format-11
Reviewer: Stewart Bryant
Review Date: 2024-10-01
IETF LC End Date: 2024-10-23
IESG Telechat date: Not scheduled for a telechat

Summary: A well written document that could be sent to the RFC Editor, but
ought to have a number of minor issues addressed first.

Major issues: None

Minor issues:
The document has six authors which I note are from the same company, when the
maximum permitted by the IETF is normally five.

=======

The text says:
   Shared brotli extends brotli [RFC7932] with support for shared
   dictionaries, larger LZ77 window and a framing format.
it says similar in other places but not those words.

Nits picks that and the draft header up and says:

  -- The draft header indicates that this document updates RFC7932, but the
     abstract doesn't seem to mention this, which it should.
======

Nits/editorial comments:
      * The framing format is a container format that allows to store
        multiple resources and refer to dictionaries.
Incorrect grammar perhaps:
      * The framing format is a container format that allows storage of
        multiple resources and that reference dictionaries.
or perhaps:
      * The framing format is a container format that allows the protocol to
      store
        multiple resources and refer to dictionaries.
======

This prevents an adversary to use a private dictionary with user secrets
to compress content hosted on the adversary's origin.

Incorrect grammar, perhaps
This prevents an adversary from using a private dictionary with user secrets
to compress content hosted on the adversary's origin.

=======