JSContact: Converting from and to vCard
draft-ietf-calext-jscontact-vcard-15

Thanks to Paul Kyzivat for the ARTART review.

Thanks to the working group.  It's clear this took a lot to pull together.

"Yes" isn't a very complete answer to #1 in the shepherd writeup.  For question #11, it's not the case that only Standards Track documents need to address interoperability.

Many "SHOULD" and "SHOULD NOT" instances left me wondering "why?"  Some examples: 2.3.10, 2.7.1, 2.9.3.  It would be helpful to understand why these (and others) aren't "MUST [NOT]", or in what cases one might legitimately decide to deviate from what it says.

# GEN AD review of draft-ietf-calext-jscontact-vcard-07

CC @larseggert

Thanks to Russ Housley for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/8_hl1kpXskr0y8aUmQzzSG8W5sE).

## Discuss

### Missing "Updates" explanation

This document updates RFC6350, but does not seem to include explanatory text
about this in the abstract.

## Comments

### Section 2.8.6, paragraph 4
```
     SOCIALPROFILE;SERVICE-TYPE=Twitter:https://twitter.com/ietf
  
     "onlineServices": {
       ...
       "OS-1": {
         "@type": "OnlineService",
         "service": "Twitter",
         "user": "https://twitter.com/ietf",
         "kind": "uri"
       }
     }
```
Might be better to use an example domain here?

### Uncited references

Document updates `RFC6350`, but does not cite it as a reference, which is a bit
odd.

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Outdated references

Document references `draft-ietf-calext-jscontact-08`, but `-09` is the latest
available revision.

### URLs

These URLs in the document can probably be converted to HTTPS:

 * http://www.iit.cnr.it

### Grammar/style

#### Section 1.3, paragraph 1
```
c. 2.1.2. Choosing identifiers Multi-valued properties in JSContact typically
                               ^^^^^^^^^^^^
```
This word is normally spelled as one.

#### Section 2.3.10, paragraph 6
```
ASCII characters to demonstrate multi-lingual content. The ASCII-formatted v
                                ^^^^^^^^^^^^^
```
This word is normally spelled as one.

#### Section 2.10.6, paragraph 5
```
 UID conversion example 2.12.9. URL An URL property converts to an entry in t
                                    ^^
```
Use "A" instead of "An" if the following word doesn't start with a vowel sound,
e.g. "a sentence", "a university".

#### Section 2.13.1, paragraph 5
```
ue. The root of the JSON pointer always is the Card object that this vCard c
                                 ^^^^^^^^^
```
The adverb "always" usually goes after the verb "is".

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool