Skip to main content

Last Call Review of draft-ietf-bier-php-12
review-ietf-bier-php-12-genart-lc-eggert-2024-11-03-00

Request Review of draft-ietf-bier-php
Requested revision No specific revision (document currently at 14)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2024-10-10
Requested 2024-09-26
Authors Zhaohui (Jeffrey) Zhang
I-D last updated 2024-11-03
Completed reviews Rtgdir Last Call review of -11 by Andy Smith (diff)
Secdir Last Call review of -12 by Shawn M Emery (diff)
Opsdir Last Call review of -12 by Jen Linkova (diff)
Genart Last Call review of -12 by Lars Eggert (diff)
Assignment Reviewer Lars Eggert
State Completed
Request Last Call review on draft-ietf-bier-php by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/3tjp7yC6DoClZoWPb0jLwvjUXYk
Reviewed revision 12 (document currently at 14)
Result Ready w/nits
Completed 2024-11-03
review-ietf-bier-php-12-genart-lc-eggert-2024-11-03-00
# genart-lc review of draft-ietf-bier-php-12

CC @larseggert

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed by
the IESG for the IETF Chair. Please treat these comments just like
any other last call comments. For more information, please see the
[FAQ](https://wiki.ietf.org/group/gen/GenArtFAQ).

## Comments

## Comments

### Section 2, paragraph 2
```
     The procedures outlined in this section are applicable only if,
     through means outside the scope of this document, it is established
     that all potential penultimate hop BFRs are capable of supporting PHP
     (i.e., able to remove the BIER header when forwarding to a requesting
     flow overlay router) and that the payload following the BIER header
     is one of the following:
```
This paragraph would benefit from the use of RFC2119 language.

### Inclusive language

Found terminology that should be reviewed for inclusivity; see
https://www.rfc-editor.org/part2/#inclusive_language for background and more
guidance:

 * Term `traditional`; alternatives might be `classic`, `classical`, `common`,
   `conventional`, `customary`, `fixed`, `habitual`, `historic`,
   `long-established`, `popular`, `prescribed`, `regular`, `rooted`,
   `time-honored`, `universal`, `widely used`, `widespread`
 * Term `natively`; alternatives might be `built-in`, `fundamental`,
   `ingrained`, `intrinsic`, `original`

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### Outdated references

Document references `draft-ietf-bier-idr-extensions-11`, but `-14` is the
latest available revision.

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF]. You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].
[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool