Telechat Review of draft-ietf-cbor-tags-oid-06
review-ietf-cbor-tags-oid-06-iotdir-telechat-robles-2021-04-06-00
Request | Review of | draft-ietf-cbor-tags-oid |
---|---|---|
Requested revision | No specific revision (document currently at 08) | |
Type | Telechat Review | |
Team | Internet of Things Directorate (iotdir) | |
Deadline | 2021-04-06 | |
Requested | 2021-04-02 | |
Requested by | Éric Vyncke | |
Authors | Carsten Bormann | |
I-D last updated | 2021-04-06 | |
Completed reviews |
Genart Last Call review of -05
by Gyan Mishra
(diff)
Iotdir Telechat review of -06 by Ines Robles (diff) |
|
Comments |
Sorry for the short-term request. |
|
Assignment | Reviewer | Ines Robles |
State | Completed | |
Request | Telechat review on draft-ietf-cbor-tags-oid by Internet of Things Directorate Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/iot-directorate/YgH5Q87V4_gVXB1bsJhzsPNNYHk | |
Reviewed revision | 06 (document currently at 08) | |
Result | Ready w/nits | |
Completed | 2021-04-06 |
review-ietf-cbor-tags-oid-06-iotdir-telechat-robles-2021-04-06-00
Summary: The document defines CBOR tags for object identifiers (OIDs). The document is well written. Few minor questions/comments. Major Issues: None Minor Issues: None Nits: - It would be nice to expand SDNV in section 1.1 instead of Section 2. - Section 3.2 - Figure 4-MIB relative object identifier in CBOR: 0b010_01001 should be 0b010_00011 ? for major type 2, additional information 3 bytes - Section 7.1: -- In order to mention the registry, maybe smth like to assign the CBOR tags --> to assign in the CBOR tags registry the following tags.... -- It would be nice to have the table with the same structure as the registry table (add reference column like in Section 7.2), I think template column does not apply here. - Section 7.2: -- In order to mention the registry, maybe smth similar as Section 7.1? Thank you for this document, Ines.