Last Call Review of draft-ietf-detnet-yang-18
review-ietf-detnet-yang-18-tsvart-lc-ott-2023-12-20-00

This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

This document describes a YANG model for Detnet nodes and layers, addressing
configuration and monitoring of the different entities.  The Detnet YANG
model has limited extra bearing on transport (beyond what Detnet already
does): the model just allows accessing and controlling Detnet nodes, the
protocols for doing are also separately specified.

With this, assuming that the underlying Detnet mechanisms function properly,
the YANG model should not be able to introduce additional transport layer
issues that would need to be considered.  Detnet also defines its own flow
specification for traffic description. Detnet itself resides below the
transport layer and may use service differentiation by various means so that
the traffic inside a Detnet class is separated from that on the outside,
but this should not affect the various traffic flows within a given class.

Again, the YANG model only assists configuration.  I trust the YANG expert
reviews on the details of the model, which seem to have been discussed before.

Nits:

One may argue if section 4 could offer a bit more context; but, then, one may
expect that those who would read this document would be intimately familiar
with the Detnet architecture and terminology in the first place.  If more
stand-alone usage was intended, section 4 could be expanded a bit.

The draft ,misses quite a few articles "the" in front of nouns, quite prominently
in the last bullet list in the beginning of each bullet item, but also 
occasionally in other places.

So, nothing major, but I wanted to still point out these two bits.