Skip to main content

Last Call Review of draft-ietf-dnsop-avoid-fragmentation-15
review-ietf-dnsop-avoid-fragmentation-15-tsvart-lc-kuehlewind-2023-10-22-00

Request Review of draft-ietf-dnsop-avoid-fragmentation
Requested revision No specific revision (document currently at 20)
Type Last Call Review
Team Transport Area Review Team (tsvart)
Deadline 2023-10-27
Requested 2023-10-13
Authors Kazunori Fujiwara , Paul A. Vixie
I-D last updated 2023-10-22
Completed reviews Dnsdir Telechat review of -16 by Vladimír Čunát (diff)
Artart Telechat review of -16 by Barry Leiba (diff)
Secdir Telechat review of -16 by Donald E. Eastlake 3rd (diff)
Dnsdir Last Call review of -15 by Vladimír Čunát (diff)
Artart Last Call review of -15 by Barry Leiba (diff)
Tsvart Last Call review of -15 by Mirja Kühlewind (diff)
Dnsdir Last Call review of -13 by Vladimír Čunát (diff)
Secdir Last Call review of -15 by Donald E. Eastlake 3rd (diff)
Genart Last Call review of -15 by Christer Holmberg (diff)
Assignment Reviewer Mirja Kühlewind
State Completed
Request Last Call review on draft-ietf-dnsop-avoid-fragmentation by Transport Area Review Team Assigned
Posted at https://mailarchive.ietf.org/arch/msg/tsv-art/yMskGev3MX-Yha1nKbEzMjowRmE
Reviewed revision 15 (document currently at 20)
Result Ready w/issues
Completed 2023-10-22
review-ietf-dnsop-avoid-fragmentation-15-tsvart-lc-kuehlewind-2023-10-22-00
This document has been reviewed as part of the transport area review team's
ongoing effort to review key IETF documents. These comments were written
primarily for the transport area directors, but are copied to the document's
authors and WG to allow them to address any issues raised and also to the IETF
discussion list for information.

When done at the time of IETF Last Call, the authors should consider this
review as part of the last-call comments they receive. Please always CC
tsv-art@ietf.org if you reply to or forward this review.

Thanks for the document; it's straight-forward but probably important to write
down.

I have two editorial comments and one request:

1) I would really recommend including "IP" in the document title to be absolute
clear about the scope. So renaming to "IP Fragmentation Avoidance in DNS".

2) This sentence is really hard to read:
  "TCP avoids fragmentation using its Maximum Segment Size (MSS)
   parameter, but each transmitted segment is header-size aware such
   that the size of the IP and TCP headers is known, as well as the far
   end's MSS parameter and the interface or path MTU, so that the
   segment size can be chosen so as to keep the each IP datagram below a
   target size."
Maybe split it into two sentences:
  "TCP avoids fragmentation by segmenting data into packets that are smaller
   than or equal to the Maximum Segment Size (MSS). As for each transmitted
   segment the size of the IP and TCP headers is known, the IP packet size can
   be chosen to keep it below the other end's MSS and path MTU."

3) In R8 you mention a timeout. Is it already anywhere specified how to set
such a time for DNS retransmissions? If so, I think a reference would be
useful. If not, more guidance is need to avoid network overload.