Last Call Review of draft-ietf-ipsecme-labeled-ipsec-10
review-ietf-ipsecme-labeled-ipsec-10-genart-lc-robles-2023-04-10-00
| Request | Review of | draft-ietf-ipsecme-labeled-ipsec |
|---|---|---|
| Requested revision | No specific revision (document currently at 12) | |
| Type | Last Call Review | |
| Team | General Area Review Team (Gen-ART) (genart) | |
| Deadline | 2023-04-10 | |
| Requested | 2023-03-20 | |
| Authors | Paul Wouters , Sahana Prasad | |
| I-D last updated | 2023-04-10 | |
| Completed reviews |
Genart Last Call review of -10
by Ines Robles
(diff)
Secdir Last Call review of -09 by Stephen Farrell (diff) Secdir Last Call review of -10 by Stephen Farrell (diff) |
|
| Assignment | Reviewer | Ines Robles |
| State | Completed | |
| Request | Last Call review on draft-ietf-ipsecme-labeled-ipsec by General Area Review Team (Gen-ART) Assigned | |
| Posted at | https://mailarchive.ietf.org/arch/msg/gen-art/gTc6yk7Q4jKh4sNNEQREidgJa70 | |
| Reviewed revision | 10 (document currently at 12) | |
| Result | Ready w/nits | |
| Completed | 2023-04-10 |
review-ietf-ipsecme-labeled-ipsec-10-genart-lc-robles-2023-04-10-00
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://trac.ietf.org/trac/gen/wiki/GenArtfaq>. Document: draft-ietf-ipsecme-labeled-ipsec-10 Reviewer: Ines Robles Review Date: 2023-04-10 IETF LC End Date: 2023-04-10 IESG Telechat date: Not scheduled for a telechat Summary: This document defines a new Traffic Selector (TS) Type for Internet Key Exchange version 2 to add support for negotiating Mandatory Access Control (MAC) security labels as a traffic selector of the Security Policy Database (SPD). The new TS type is TS_SECLABEL. The document is well written and easy to read. Major issues: None Minor issues: None Nits/editorial comments: Section 3.2: "198.51.0/24" --> "198.51.100.0/24" ? Question: Section 2.1, the Security Label should be at least of one octet. Is there a limit of octets for this field? Thank you for this document, Ines.