Last Call Review of draft-ietf-isis-segment-routing-extensions-20
review-ietf-isis-segment-routing-extensions-20-rtgdir-lc-white-2018-11-11-00

Request Review of draft-ietf-isis-segment-routing-extensions
Requested rev. no specific revision (document currently at 25)
Type Last Call Review
Team Routing Area Directorate (rtgdir)
Deadline 2018-12-14
Requested 2018-11-08
Requested by Acee Lindem
Authors Stefano Previdi, Les Ginsberg, Clarence Filsfils, Ahmed Bashandy, Hannes Gredler, Bruno Decraene
Draft last updated 2018-11-11
Completed reviews Rtgdir Last Call review of -20 by Russ White (diff)
Rtgdir Last Call review of -23 by Russ White (diff)
Genart Last Call review of -23 by Erik Kline (diff)
Assignment Reviewer Russ White
State Completed
Review review-ietf-isis-segment-routing-extensions-20-rtgdir-lc-white-2018-11-11
Reviewed rev. 20 (document currently at 25)
Review result Has Nits
Review completed: 2018-11-11

Review
review-ietf-isis-segment-routing-extensions-20-rtgdir-lc-white-2018-11-11

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-isis-segment-routing-extensions-20
Reviewer: Russ White
Review Date: 10 November 2018
IETF LC End Date: 12 December 2018
Intended Status: Standards Track

Summary: 

This document is basically ready for publication, but has nits that should be considered prior to publication.

Overall, this document is well written, and the mechanisms described are well thought out. 

Major Issues:

No major issues found.

Minor Issues:

No minor issues found.

Nits:

Section 2.1

Algorithms identifiers are defined in Section 3.2.

"Algorithm" rather than "Algorithms."

Sections 2.1 and 2.2

"Length" is listed as "variable," but not further definition is provided. From the text it seems like valid values here would be 3 or 20, in octets, as this is explicit in section 2.3, but it might be good to clarify (ie, just copy the text for "Length" in section 2.3 to these sections as well).

😊 /r