Last Call Review of draft-ietf-jmap-sieve-17
review-ietf-jmap-sieve-17-genart-lc-robles-2024-02-02-00
Request | Review of | draft-ietf-jmap-sieve |
---|---|---|
Requested revision | No specific revision (document currently at 22) | |
Type | Last Call Review | |
Team | General Area Review Team (Gen-ART) (genart) | |
Deadline | 2024-02-01 | |
Requested | 2024-01-18 | |
Authors | Kenneth Murchison | |
I-D last updated | 2024-02-02 | |
Completed reviews |
Genart Last Call review of -17
by Ines Robles
(diff)
Secdir Last Call review of -19 by Mohit Sethi (diff) Artart Last Call review of -16 by Rich Salz (diff) |
|
Assignment | Reviewer | Ines Robles |
State | Completed | |
Request | Last Call review on draft-ietf-jmap-sieve by General Area Review Team (Gen-ART) Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/gen-art/oWprLkDefcnQNfqsGaXbhSH1EKs | |
Reviewed revision | 17 (document currently at 22) | |
Result | Ready w/nits | |
Completed | 2024-02-02 |
review-ietf-jmap-sieve-17-genart-lc-robles-2024-02-02-00
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <https://wiki.ietf.org/en/group/gen/GenArtFAQ>. Document: draft-ietf-jmap-sieve-17 Reviewer: Ines Robles Review Date: 2024-02-02 IETF LC End Date: 2024-02-01 IESG Telechat date: Not scheduled for a telechat Summary: The document specifies a data model for managing Sieve scripts using JMAP, a protocol for synchronizing data such as email between clients and servers. The model also includes details about server capabilities, script properties, activation, and validation processes. The document is well written. I have minor comments/questions below. Major issues: None Minor issues: None Nits/editorial comments: 1- Section 1: "...however the functionality offered over the two protocols may differ" It would be nice to clarify How the protocols may differ, for example, what about: "While both JMAP and ManageSieve provide mechanisms for managing Sieve scripts on a server, the range of features and operations available may vary between the two protocols. This could affect how scripts are created, edited, or executed, depending on which protocol is used." or something like that. What do you think? 2- Section 1.3.1: "This represents support..." --> Perhaps: "The urn:ietf:params:jmap:sieve capability object represents support..." ? 3- Section 2.2: "...This method provides similar functionality to the PUTSCRIPT, DELETESCRIPT, RENAMESCRIPT, and SETACTIVE commands in [RFC5804]." It would be nice to clarify a bit in which aspects are similar/dissimilar, for example, what about: "This method provides similar functionality to the PUTSCRIPT, DELETESCRIPT, RENAMESCRIPT, and SETACTIVE commands in [RFC5804]. Similar functionality here means that, though the protocols differ, the JMAP method achieves the same end goals (e.g. managing Sieve scripts by allowing their creation, deletion, renaming, and activation)" Is this correct? What do you think? Thanks for this document, Ines.