Last Call Review of draft-ietf-kitten-krb-spake-preauth-07
review-ietf-kitten-krb-spake-preauth-07-genart-lc-housley-2020-05-15-00

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-kitten-krb-spake-preauth-07
Reviewer: Russ Housley
Review Date: 2020-05-15
IETF LC End Date: 2020-05-26
IESG Telechat date: Unknown


Summary: Almost Ready

Major Concerns:

Section 1.2: A reference is needed for the "SPAKE algorithm" is
needed here, even if it is a forward pointer to Section 2.
Does this align with draft-irtf-cfrg-spake2?  Are you aware of
https://datatracker.ietf.org/ipr/4018/?


Minor Concerns:

Abstract: Please explain "FAST", perhaps just a pointer to RFC 6113.

Section 7 says:

   First, the hash function associated with the selected group is
   computed over the concatenation of the following values:

A hash value is being computed, not a group.


Nits:

General: Please prepare for publication as an RFC by changing "this
draft" to something that is appropriate for an archival series document.

Section 1: In the first paragraph, we see: "preauthentication".  Then,
in the first paragraph of Section 1.1, we see "pre-authentication".
Please pick one.


Note:  I did not try to compile the ASN.1 or run the python script.