Last Call Review of draft-ietf-lamps-ocsp-nonce-03
review-ietf-lamps-ocsp-nonce-03-secdir-lc-turner-2020-09-01-00

Request Review of draft-ietf-lamps-ocsp-nonce
Requested revision No specific revision (document currently at 05)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2020-09-02
Requested 2020-08-19
Authors Mohit Sahni
I-D last updated 2020-09-01
Completed reviews Genart Last Call review of -03 by Francesca Palombini (diff)
Secdir Last Call review of -03 by Sean Turner (diff)
Opsdir Last Call review of -03 by Linda Dunbar (diff)
Assignment Reviewer Sean Turner
State Completed
Request Last Call review on draft-ietf-lamps-ocsp-nonce by Security Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/secdir/1TASQdslNtS__AuhT-L3fk8hk38
Reviewed revision 03 (document currently at 05)
Result Has nits
Completed 2020-09-01
review-ietf-lamps-ocsp-nonce-03-secdir-lc-turner-2020-09-01-00
The is short little document that put size constraints on the OCPS nonce
extension. In particular, it requires the nonce be between 1 and 32 octets
long. Since there's no bits on the wire changes, I think it's fine there's no
new ASN.1 module.

My technical nits include:

0. s2.1: Consider also throwing an error if the OCTET STRING is zero bytes in
length. You throw one if it's too long, but not if it's too short.

1. s2.1, 4th paragraph: Consider adding reference to RFC 4086 for randomness
requirements.

My editorial nits include:

0. Abstract: missing period at the end of paragraph.

1. s2.1, 3rd para: missing period at end of paragraph

2. s4: I think the indentation is off by a couple of characters.