Last Call Review of draft-ietf-lamps-pkcs12-pbmac1-07
review-ietf-lamps-pkcs12-pbmac1-07-genart-lc-even-2024-02-14-00

Request Review of draft-ietf-lamps-pkcs12-pbmac1
Requested revision No specific revision (document currently at 09)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2024-02-22
Requested 2024-02-08
Authors Alicja Kario
I-D last updated 2024-02-14
Completed reviews Genart Last Call review of -07 by Roni Even (diff)
Opsdir Last Call review of -08 by Gyan Mishra (diff)
Assignment Reviewer Roni Even
State Completed
Request Last Call review on draft-ietf-lamps-pkcs12-pbmac1 by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/YzUb9OiYgGwJEAPmGpmQ9Ksn-Xw
Reviewed revision 07 (document currently at 09)
Result Ready w/nits
Completed 2024-02-14
review-ietf-lamps-pkcs12-pbmac1-07-genart-lc-even-2024-02-14-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-lamps-pkcs12-pbmac1-??
Reviewer: Roni Even
Review Date: 2024-02-13
IETF LC End Date: 2024-02-22
IESG Telechat date: Not scheduled for a telechat

Summary:
The document is ready for publication as an informational RFC with nits

Major issues:

Minor issues:

Nits/editorial comments:
1. Section 3 if needed should include the reference to RC8174 as in the
following text: “The key words "MUST", "MUST NOT", "REQUIRED", "SHALL", "SHALL
NOT", "SHOULD", "SHOULD NOT", "RECOMMENDED", "NOT RECOMMENDED", "MAY", and
"OPTIONAL" in this document are to be interpreted as described in BCP 14
[RFC2119] [RFC8174] when, and only when, they appear in all capitals, as shown
here.”

2. In appendix B you should have a note to the RFC editor to relocate the TBD
value with the value assigned by IANA