Last Call Review of draft-ietf-lisp-lcaf-15

Request Review of draft-ietf-lisp-lcaf
Requested rev. no specific revision (document currently at 22)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2016-10-04
Requested 2016-09-22
Authors Dino Farinacci, David Meyer, Job Snijders
Draft last updated 2016-09-29
Completed reviews Genart Last Call review of -15 by Peter Yee (diff)
Genart Last Call review of -17 by Peter Yee (diff)
Secdir Last Call review of -15 by David Mandelberg (diff)
Opsdir Last Call review of -15 by Sarah Banks (diff)
Rtgdir Early review of -14 by Stig Venaas (diff)
Assignment Reviewer David Mandelberg 
State Completed
Review review-ietf-lisp-lcaf-15-secdir-lc-mandelberg-2016-09-29
Reviewed rev. 15 (document currently at 22)
Review result Has Nits
Review completed: 2016-09-29



I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the IESG.
These comments were written primarily for the benefit of the security
area directors.  Document editors and WG chairs should treat these
comments just like any other last call comments.

I found one issue in various parts of the document (described below),
but I'm not sure it's relevant to security. If it is, then I think this
document is Almost Ready. If not, then I think this document is Ready
With Nits.

There are multiple places in the document where it's possible to encode
semantically equivalent information in multiple ways, despite the word
"canonical" being in the title of the document. Is there anything that
relies on these addresses being canonical for security purposes?

Multiple places in the document (sections 4.1, 4.5, and 4.8) specify
mask lengths, but do not specify that the masked out bits MUST be set to

Section 4.4: The description of RTR RLOC Address gives two different
ways to encode an address with zero RTRs.

Section 4.10.5: If I understand the compatibility mode correctly, this
explicitly creates a second way to encode a semantically identical address.

Section 5.4: There are many different ways to encode equivalent JSON
data here.

Section 6 (Security Considerations): There is no discussion of these
addresses being canonical, and what other systems might or might not
rely on these addresses being canonical.

I also have some questions/nits:

Section 3: Shouldn't the LCAF sort-key of {afi, LCAF-Type} also include
the RLOC-address or LCAF payload?

Section 4.3: Altitude is described as a signed integer, but this
document doesn't specify the encoding. I assume it's two's complement,
but that should probably be made explicit.

Section 4.7: The Key Count description talks about "Key sections," but
doesn't say which fields are part of the key section (and can thus be
repeated). I have a guess which fields are part of the key section, but
it's not entirely clear.

Section 4.7: The Key Algorithm description doesn't point to a registry
of valid values or otherwise say how to interpret values in that field.

David Eric Mandelberg / dseomn




 OpenPGP digital signature