Telechat Review of draft-ietf-lsr-pce-discovery-security-support-12
review-ietf-lsr-pce-discovery-security-support-12-intdir-telechat-pignataro-2022-10-11-00

Request Review of draft-ietf-lsr-pce-discovery-security-support
Requested revision No specific revision (document currently at 13)
Type Telechat Review
Team Internet Area Directorate (intdir)
Deadline 2022-10-02
Requested 2022-09-23
Requested by Éric Vyncke
Authors Diego Lopez , Qin Wu , Dhruv Dhody , Qiufang Ma , Daniel King
I-D last updated 2022-10-11
Completed reviews Secdir Last Call review of -05 by Yaron Sheffer (diff)
Rtgdir Last Call review of -05 by Ron Bonica (diff)
Opsdir Last Call review of -10 by Will (Shucheng) LIU (diff)
Intdir Telechat review of -12 by Carlos Pignataro (diff)
Opsdir Telechat review of -13 by Will (Shucheng) LIU
Assignment Reviewer Carlos Pignataro
State Completed
Request Telechat review on draft-ietf-lsr-pce-discovery-security-support by Internet Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/int-dir/5cIHA2XXfVKcYRNHG2r9ktCHPfA
Reviewed revision 12 (document currently at 13)
Result Ready w/nits
Completed 2022-10-11
review-ietf-lsr-pce-discovery-security-support-12-intdir-telechat-pignataro-2022-10-11-00
This document defines a mechanism (flags and sub-TLV) to advertise via the PCE
Protocol security required within the IGP being used.

This is a very well written, clear, and sensible document. In my opinion, it is 
Ready.

Flagging some potential nits:

Abstract:
Old:
   capability.  Further, this document updates RFC 8231, and RFC 8306.
New:
   capability.  Further, this document updates RFC 8231 and RFC 8306.

Question:
The header and Section 4 say this updates RFCs 5088 and 5089; however, 
that is not mentioned in the Abstract.

Old:
   The YANG model for PCEP [I-D.ietf-pce-pcep-yang] supports PCEP
   security parameters (key, key chain and TLS).
New:
   The YANG model for PCEP [I-D.ietf-pce-pcep-yang] supports PCEP
   security parameters (key, key chain, and TLS).

Thanks!

Carlos.