Skip to main content

Last Call Review of draft-ietf-lsvr-bgp-spf-39
review-ietf-lsvr-bgp-spf-39-secdir-lc-mandelberg-2024-12-02-00

Request Review of draft-ietf-lsvr-bgp-spf
Requested revision No specific revision (document currently at 51)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2024-12-09
Requested 2024-11-26
Requested by Jim Guichard
Authors Keyur Patel , Acee Lindem , Shawn Zandi , Wim Henderickx
I-D last updated 2024-12-02
Completed reviews Opsdir Early review of -01 by Fred Baker (diff)
Rtgdir Early review of -02 by Dan Frost (diff)
Rtgdir Last Call review of -13 by Yingzhen Qu (diff)
Rtgdir Last Call review of -31 by Adrian Farrel (diff)
Genart Last Call review of -39 by Joel M. Halpern (diff)
Secdir Last Call review of -39 by David Mandelberg (diff)
Rtgdir Last Call review of -39 by Alvaro Retana (diff)
Assignment Reviewer David Mandelberg
State Completed
Request Last Call review on draft-ietf-lsvr-bgp-spf by Security Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/secdir/Ifk6w3o5LyABfODqaXr6xnn3NQI
Reviewed revision 39 (document currently at 51)
Result Ready
Completed 2024-12-02
review-ietf-lsvr-bgp-spf-39-secdir-lc-mandelberg-2024-12-02-00
Overall, looks good. I have one question which might be relevant to security,
but I'm not sure.

Sections 5.2.1.1, 5.2.2.2, and 5.2.3.1 say "The BGP-LS-SPF Node NLRI Attribute
SPF Status TLV, Link NLRI Attribute SPF Status TLV, and Prefix NLRI Attribute
SPF Status TLV use the same TLV Type (1184). This implies that a BGP Update
will include a single NLRI." Is it possible to have multiple NLRI of different
types in the same update? Maybe it's worth adding a MUST NOT about that, and
adding something to section 7 about how to handle that case?