IETF Last Call Review of draft-ietf-mpls-spring-lsp-ping-path-sid-06
review-ietf-mpls-spring-lsp-ping-path-sid-06-opsdir-lc-liu-2025-04-30-00

Request Review of draft-ietf-mpls-spring-lsp-ping-path-sid
Requested revision No specific revision (document currently at 13)
Type IETF Last Call Review
Team Ops Directorate (opsdir)
Deadline 2025-04-21
Requested 2025-04-07
Requested by Jim Guichard
Authors Xiao Min , Shaofu Peng , Liyan Gong , Rakesh Gandhi , Carlos Pignataro
I-D last updated 2025-10-29 (Latest revision 2025-06-06)
Completed reviews Rtgdir Early review of -01 by Ben Niven-Jenkins (diff)
Secdir IETF Last Call review of -05 by Jon Geater (diff)
Opsdir IETF Last Call review of -06 by Bing Liu (diff)
Rtgdir IETF Last Call review of -12 by Andy Smith (diff)
Assignment Reviewer Bing Liu
State Completed
Request IETF Last Call review on draft-ietf-mpls-spring-lsp-ping-path-sid by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/eNIZnUr6m6pUMLW_5yfS9oV9eCw
Reviewed revision 06 (document currently at 13)
Result Has nits
Completed 2025-04-30
review-ietf-mpls-spring-lsp-ping-path-sid-06-opsdir-lc-liu-2025-04-30-00
Hi Dear author, I'm assigned to review
draft-ietf-mpls-spring-lsp-ping-path-sid-06 by OPSDir.

General status: Has Nits
This document is a concrete proposal of defining PSID FEC sub TLVs for LSP
Ping. The content and node behavior of the sub-TLVs is well specified in
details. No problems found in tehchnical perspective.

The Nit:
I've been a bit confusing of what is the usage of the newly defined TLVs when
firstly read the draft. Then I found it might be mainly for verification of the
conformance between the control plane and the data plane for a given FEC, based
on some texts "hidden" in the sub-TLV definition section. (And yet, not very
sure whether there might be other usage.) I'd suggest to add some
background/scenarios description in Section 1 and also summarize it in the
abstract. I believe it would be very helpful to navigate the readers who don't
know the bachground of this work.

B.R.
Bing