Early Review of draft-ietf-netmod-intf-ext-yang-16
review-ietf-netmod-intf-ext-yang-16-yangdoctors-early-bierman-2025-03-31-00

Request Review of draft-ietf-netmod-intf-ext-yang-15
Requested revision 15 (document currently at 18)
Type Early Review
Team YANG Doctors (yangdoctors)
Deadline 2025-04-01
Requested 2025-03-18
Requested by Lou Berger
Authors Robert Wilton , Scott Mansfield
I-D last updated 2025-10-19 (Latest revision 2025-10-19)
Completed reviews Yangdoctors Early review of -04 by Andy Bierman (diff)
Yangdoctors Early review of -16 by Andy Bierman (diff)
Intdir IETF Last Call review of -17 by Satoru Matsushima (diff)
Opsdir IETF Last Call review of -17 by Sheng Jiang (diff)
Tsvart IETF Last Call review of -17 by Michael Scharf (diff)
Genart IETF Last Call review of -17 by Reese Enghardt (diff)
Comments 
There was an earlier review conducted.  The model has not seen significant change, but should be reviewed as part of the pre publication process.

Thank you!
Assignment Reviewer Andy Bierman
State Completed
Request Early review on draft-ietf-netmod-intf-ext-yang by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/YB4ybV1RRT-nXgdQietaSgsm11s
Reviewed revision 16 (document currently at 18)
Result Ready w/nits
Completed 2025-03-31
review-ietf-netmod-intf-ext-yang-16-yangdoctors-early-bierman-2025-03-31-00
Modules:
- ietf-if-ethernet-like@2025-01-27
- ietf-if-extensions@2025-01-27

Almost perfect.

I found 1 nit in ietf-if-ethernet-like:mac-address

OLD:

      leaf mac-address {
        if-feature "configurable-mac-address";
        type yang:mac-address;
        description
          "The MAC address of the interface.  The operational value
           matches the /if:interfaces/if:interface/if:phys-address
           leaf defined in ietf-interface.yang.";
      }

NEW:
      leaf mac-address {
        if-feature "configurable-mac-address";
        type yang:mac-address;
        description
          "The MAC address of the interface.  The operational value
           matches the /if:interfaces/if:interface/if:phys-address
           leaf defined in the ietf-interfaces YANG module (RFC 8343).";
      }