Last Call Review of draft-ietf-netmod-system-config-06
review-ietf-netmod-system-config-06-yangdoctors-lc-vasko-2024-06-13-00

Request Review of draft-ietf-netmod-system-config
Requested revision No specific revision (document currently at 09)
Type Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2024-06-17
Requested 2024-06-03
Requested by Kent Watsen
Authors Qiufang Ma , Qin Wu , Chong Feng
I-D last updated 2024-06-13
Completed reviews Yangdoctors Last Call review of -06 by Michal Vaško (diff)
Assignment Reviewer Michal Vaško
State Completed
Request Last Call review on draft-ietf-netmod-system-config by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/cv_4J_bkGmZg2y3f1yknBrtwIfY
Reviewed revision 06 (document currently at 09)
Result Ready w/nits
Completed 2024-06-13
review-ietf-netmod-system-config-06-yangdoctors-lc-vasko-2024-06-13-00
This is my yang-doctor review of draft-ietf-netmod-system-config, which
includes 2 small YANG modules, in addition to a few example modules.

ietf-system-datastore:
- small module with a single identity, no issues

ietf-netconf-resolve-system:
- module with similar simple augments to standard ietf-netconf and
ietf-netconf-nmda modules, no issues

As for the example YANG modules and data, there are a few nits:

example-acl:
- leaf-list application - path is not indented

Section 8.2 BGP examples:
- 'inet:port' type does not exist in the latest ietf-inet-types (2013) YANG
module, only 'port-number' - all 'local-as' and 'peer-as' nodes are uint32, so
in JSON encoding numbers should be used instead of strings - 'local-port' is
using uint16 type so in JSON encoding numbers should be used instead of strings

Finally, the examples and their data are using YANG snippets and data without
namespaces or module names, which may be fine for illustration purposes but
possibly confusing.