Skip to main content

Last Call Review of draft-ietf-opsawg-add-encrypted-dns-07

Request Review of draft-ietf-opsawg-add-encrypted-dns
Requested revision No specific revision (document currently at 12)
Type Last Call Review
Team DNS Directorate (dnsdir)
Deadline 2022-10-27
Requested 2022-10-12
Requested by Joe Clarke
Authors Mohamed Boucadair , Tirumaleswar Reddy.K , Alan DeKok
I-D last updated 2023-01-11
Completed reviews Dnsdir Last Call review of -07 by Ralf Weber (diff)
Genart Last Call review of -09 by Robert Sparks (diff)
Intdir Telechat review of -10 by Tatuya Jinmei (diff)
Dnsdir Telechat review of -10 by Ralf Weber (diff)
Assignment Reviewer Ralf Weber
State Completed
Review review-ietf-opsawg-add-encrypted-dns-07-dnsdir-lc-weber-2023-01-11
Posted at
Reviewed revision 07 (document currently at 12)
Result Ready with Nits
Completed 2023-01-11

I'm the assigned reviewer of the DNS Directorate for this draft. Given that the
add working group defines drafts for getting encrypted DNS resolver settings to
clients I was initially surprised to see this draft coming from ops area to the
DNS directorate for review.

However looking into while reviewing it is this has become clear as the
attributes defined by add DNR draft are just one user of the specification of
this draft. The draft uses and existing specifications on interactions between
DHCP and Radius and adds DNR as one use case. As such while the draft was
started with, explains this use case and does so fine there is not much for the
DNS directorate to review.

I see this draft as ready with the following nits:
- The table of attributes under 7 Table of attributes only have two values
which both start with 0. As the main distinction is that attributes MUST NOT
appear when 0 is there and MAY appeare when 0+ is defined making this boolean
with e.g Y/N seems easier to understand IMHO. - In 8.1 New Radius Attributes
the table is called "Table 1: Encrypted DNS RADIUS Attributes", while the table
describer generic DHCP Options attributes. The table name should reflect that.

So long