Last Call Review of draft-ietf-ospf-sr-yang-33
review-ietf-ospf-sr-yang-33-secdir-lc-bonnell-2025-02-06-00

My primary area of experience is PKI, and this is my first foray for delving
into YANG. I hope the comments below are useful despite that.

I have reviewed the document and found that the security considerations section
provides appropriate guidance on the use of secure transport protocols as well
as access controls for reading and writing the nodes defined in this document.
Additionally, there is sufficient enumeration of the specific risks posed by
allowing an attacker write access to the nodes defined in the document or
allowing an attacker read access to nodes. Given this, I believe the current
security considerations section is sufficient.

Nit:
In the Security Considerations section, replace "Dos" with "DoS" in several
locations for consistency.

Question:
Should the various read-only nodes defined in this document (such as
"prefix-sid-sub-tlvs") be marked as "config false" as they are not writable?