Skip to main content

Telechat Review of draft-ietf-pce-pcep-stateful-pce-gmpls-22
review-ietf-pce-pcep-stateful-pce-gmpls-22-opsdir-telechat-hares-2023-06-14-00

Request Review of draft-ietf-pce-pcep-stateful-pce-gmpls
Requested revision No specific revision (document currently at 23)
Type Telechat Review
Team Ops Directorate (opsdir)
Deadline 2023-06-06
Requested 2023-05-31
Authors Young Lee , Haomian Zheng , Oscar Gonzalez de Dios , Victor Lopez , Zafar Ali
I-D last updated 2023-06-14
Completed reviews Genart Last Call review of -21 by Stewart Bryant (diff)
Secdir Last Call review of -21 by Ivaylo Petrov (diff)
Opsdir Telechat review of -22 by Susan Hares (diff)
Rtgdir Early review of -19 by Susan Hares (diff)
Assignment Reviewer Susan Hares
State Completed
Request Telechat review on draft-ietf-pce-pcep-stateful-pce-gmpls by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/yQFmKuKr4oqyFIDqZ69MdQu200Y
Reviewed revision 22 (document currently at 23)
Result Has nits
Completed 2023-06-14
review-ietf-pce-pcep-stateful-pce-gmpls-22-opsdir-telechat-hares-2023-06-14-00
OPS-DIR review:
Status: Ready with nits
General comment: Well-written, concise, and clear. The authors did excellent
work.

NITS - in the error handling (sections 7.2, 7.3, and 7.3)

1. section 7.2, paragraph 3, last sentence starting "Such a PCC"
Old/Such a PCC MAY decide to utilize the capability even though it did not
advertise support for it./

It seems as though PCC in this sentence is a typographical error for PCE.

2. section 7.2, sentence 2,
It is unclear what happens if the "MAY clause is taken".  Does the Stateful PCE
simply report success or is it silent or does the error report get made?

Current text:/ If no LSP state information is available to carry out
re-optimization, the stateful PCE SHOULD report the error "LSP state
information unavailable for the LSP re-optimization" (Error Type = 19, Error
value= TBD6), although such a PCE MAY consider the re-optimization to have
successfully completed./

3. section 7.3. sentence 5, beginning "An implementation May choose to"
text: /An implementation MAY choose to ignore the requested exclusion when the
LSP cannot be found because it could claim it that it has avoided using all
resources associated with an LSP that doesn't exist./

Does the implementation send an error report in this case or does it positively
ack the response? The MAY clauses lack clear actions.

Thanks for your hard work on this document.