Last Call Review of draft-ietf-privacypass-auth-scheme-11
review-ietf-privacypass-auth-scheme-11-secdir-lc-atkins-2023-08-10-00

Request Review of draft-ietf-privacypass-auth-scheme
Requested revision No specific revision (document currently at 15)
Type Last Call Review
Team Security Area Directorate (secdir)
Deadline 2023-07-07
Requested 2023-06-23
Authors Tommy Pauly , Steven Valdez , Christopher A. Wood
I-D last updated 2023-08-10
Completed reviews Httpdir Telechat review of -12 by Martin Thomson (diff)
Secdir Last Call review of -11 by Derek Atkins (diff)
Opsdir Last Call review of -11 by Yingzhen Qu (diff)
Genart Last Call review of -11 by Gyan Mishra (diff)
Assignment Reviewer Derek Atkins
State Completed
Request Last Call review on draft-ietf-privacypass-auth-scheme by Security Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/secdir/-cLTyd9bEsjl7ltvX-b16TdlFQQ
Reviewed revision 11 (document currently at 15)
Result Has nits
Completed 2023-08-08
review-ietf-privacypass-auth-scheme-11-secdir-lc-atkins-2023-08-10-00
Hi,

I have reviewed this document as part of the security directorate's
ongoing effort to review all IETF documents being processed by the
IESG.  These comments were written with the intent of improving
security requirements and considerations in IETF drafts.  Comments
not addressed in last call may be included in AD reviews during the
IESG review.  Document editors and WG chairs should treat these
comments just like any other last call comments.

Summary:

* Has Nits

Details:

* You have a typo at the bottom of Page 15:
   [RFC8701]).  Implemenations SHOULD select reserved values at random

  I am guessing this should be "Implementations"  :)

* Quick question: Is there no MTI token type?  I would have expected
  at least ONE, unless your expectation are the greased values are
  your MTIs?

-derek

-- 
       Derek Atkins                 617-623-3745
       derek@ihtfp.com             www.ihtfp.com
       Computer and Internet Security Consultant