Last Call Review of draft-ietf-pwe3-iccp-stp-04
review-ietf-pwe3-iccp-stp-04-secdir-lc-emery-2015-09-24-00
Request | Review of | draft-ietf-pwe3-iccp-stp |
---|---|---|
Requested revision | No specific revision (document currently at 05) | |
Type | IETF Last Call Review | |
Team | Security Area Directorate (secdir) | |
Deadline | 2015-09-23 | |
Requested | 2015-09-10 | |
Authors | Mingui Zhang , Huafeng Wen , Jie Hu | |
I-D last updated | 2018-12-20 (Latest revision 2015-10-09) | |
Completed reviews |
Genart IETF Last Call review of -04
by Brian E. Carpenter
(diff)
Genart Telechat review of -04 by Brian E. Carpenter (diff) Secdir IETF Last Call review of -04 by Shawn M Emery (diff) |
|
Assignment | Reviewer | Shawn M Emery |
State | Completed | |
Request | IETF Last Call review on draft-ietf-pwe3-iccp-stp by Security Area Directorate Assigned | |
Reviewed revision | 04 (document currently at 05) | |
Result | Has nits | |
Completed | 2015-09-24 |
review-ietf-pwe3-iccp-stp-04-secdir-lc-emery-2015-09-24-00
I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG. These comments were written primarily for the benefit of the security area directors. Document editors and WG chairs should treat these comments just like any other last call comments. This draft specifies a Spanning Tree Protocol (STP) application for the Inter-Chassis Communication Protocol (ICCP). The security considerations section does exist and refers to the base ICCP specification, RFC 7275, for applicability. 7275 lists the security constraints and limitations sufficiently when considering the reviewed draft. The section goes on to describe potential DoS attacks as described in 7275 and provides a single example to mitigate such an attack. Even though this coverage is fairly sparse, 7275 outlines a more comprehensive list of thwarting potential threats. General comments: None. Editorial comments: PE, PW, AC, CE, and LDP are never expanded. s/need be active/need to be active/ s/such system/such systems/ s/that support ICCP/that supports ICCP/ s/on CE or PE/on the CE or PE/ s/attack on channel/attack on a channel/ s/careful attack on channel/a careful attack on a channel/ Shawn. --