Skip to main content

Last Call Review of draft-ietf-rift-yang-03

Request Review of draft-ietf-rift-yang
Requested revision No specific revision (document currently at 10)
Type Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2021-07-27
Requested 2021-07-06
Requested by Jeff Tantsura
Authors Zheng Zhang , Yuehua Wei , Shaowen Ma , Xufeng Liu , Bruno Rijsman
I-D last updated 2021-07-08
Completed reviews Yangdoctors Last Call review of -03 by Michal Vaško (diff)
Assignment Reviewer Michal Vaško
State Completed
Request Last Call review on draft-ietf-rift-yang by YANG Doctors Assigned
Posted at
Reviewed revision 03 (document currently at 10)
Result Almost ready
Completed 2021-07-08
Generally, use references where make sense (features, nodes) and use units
and/or standard types (ietf-yang-types) for leaves (such as grouping
neighbor-node/bandwidth). All links are invalid, better to use references
anyway because the module will be used outside the RFC.

Specific problems:

- description - copyright 2020
- typedef ieee802-1as-timestamp-type - reference in description, put separately
- grouping address-families
        - list with a single key can be leaf-list
        - would make sense if meant to be augmented with new nodes
- grouping node-flag
        - used only once, makes sense if meant to be reused by other modules
        - consider using bits type in the leaf
- grouping base-node-info/pod - redundant description, use union of number and
"undefined", or leave out for undefined since it is not mandatory - augment
        - default value in description - should be defined in YANG
                                                              - consider using
                                                              refine on
        rx-flood-port - redundant default in description, is obvious in YANG
        algorithm-type - empty cases - redundant on their own, are expected to
        be augmented? HAL - use lowercase
                - use hyphen instead of underscore
                - consider abbreviated/shorter node names
                - applicable for the following nodes as well