Skip to main content

Telechat Review of draft-ietf-sframe-enc-07
review-ietf-sframe-enc-07-intdir-telechat-krishnan-2024-03-29-00

Request Review of draft-ietf-sframe-enc
Requested revision No specific revision (document currently at 09)
Type Telechat Review
Team Internet Area Directorate (intdir)
Deadline 2024-03-29
Requested 2024-03-03
Requested by Éric Vyncke
Authors Emad Omara , Justin Uberti , Sergio Garcia Murillo , Richard Barnes , Youenn Fablet
I-D last updated 2024-03-29
Completed reviews Genart Last Call review of -07 by Linda Dunbar (diff)
Secdir Last Call review of -06 by Carl Wallace (diff)
Artart Last Call review of -06 by Valery Smyslov (diff)
Intdir Telechat review of -07 by Suresh Krishnan (diff)
Assignment Reviewer Suresh Krishnan
State Completed
Request Telechat review on draft-ietf-sframe-enc by Internet Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/int-dir/HOQQiM3TfSBrml8-yNIUOR5zZo8
Reviewed revision 07 (document currently at 09)
Result Ready w/nits
Completed 2024-03-29
review-ietf-sframe-enc-07-intdir-telechat-krishnan-2024-03-29-00
I found the document well written and easy to understand. I did have two minor
comments to bring up:

* The draft seems to have a few (looks like Python) code blocks embedded in it.
Consider enclosing them within <CODE BEGINS> and <CODE ENDS> markers to
identify them as code components for licensing purposes.

* The draft seems to refer to an obsoleted version of the SDP spec RFC4566
which was obsoleted by RFC8866. Unless there is something specific in the old
SDP needed for this draft, it probably makes sense to refer to the newer RFC.