Telechat Review of draft-ietf-tcpm-yang-tcp-07
review-ietf-tcpm-yang-tcp-07-opsdir-telechat-mishra-2022-07-03-00

Request Review of draft-ietf-tcpm-yang-tcp
Requested revision No specific revision (document currently at 09)
Type Telechat Review
Team Ops Directorate (opsdir)
Deadline 2022-06-28
Requested 2022-06-23
Authors Michael Scharf , Mahesh Jethanandani , Vishal Murgai
I-D last updated 2022-07-03
Completed reviews Genart Last Call review of -06 by Stewart Bryant (diff)
Yangdoctors Early review of -06 by Ebben Aries (diff)
Opsdir Last Call review of -06 by Gyan Mishra (diff)
Secdir Last Call review of -06 by Hilarie Orman (diff)
Tsvart Last Call review of -06 by Gorry Fairhurst (diff)
Secdir Telechat review of -07 by Hilarie Orman (diff)
Opsdir Telechat review of -07 by Gyan Mishra (diff)
Assignment Reviewer Gyan Mishra
State Completed
Request Telechat review on draft-ietf-tcpm-yang-tcp by Ops Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/ops-dir/tHRW4AnLXw6WiD4fd9fBoAvrbqA
Reviewed revision 07 (document currently at 09)
Result Not ready
Completed 2022-07-03
review-ietf-tcpm-yang-tcp-07-opsdir-telechat-mishra-2022-07-03-00
This draft provides the Yang data mode for TCP.

The draft is well written and is almost ready publication.  I verified the FSM
state machine and all states are listed.

Minor issues:
None

Major issues:
None

Nits:
I reviewed the TCP Yang data model and has a question related to the FSM state
machine.

Would it be possible to specify the TCP Header flags SYN, FIN, ACK, RST of BFD
FSM finite state machine Events and Transition.  I think this would be very
helpful for the TCP Yang model FSM state machine.  For each state you could
specify the flags set.

http://tcpipguide.com/free/t_TCPOperationalOverviewandtheTCPFiniteStateMachineF-2.htm

I think the TCP TCB (TCP Control Block) is missing in the Yang model. This is
important for troubleshooting TCP connection state.