Early Review of draft-ietf-teas-ietf-network-slice-nbi-yang-16
review-ietf-teas-ietf-network-slice-nbi-yang-16-yangdoctors-early-lhotka-2024-12-18-00

I also reviewed previous version -03 of this document. All my objections and
recommendations from that review have been taken into consideration, except for
this one:

In JSON representation of leafref instance values, the module prefix "ietf-nss"
cannot be used as a namespace identifier (because the prefix isn't declared in
JSON). In the namespace-qualified form, the full module name has to be used.
However, no namespace is needed here because the referred identities are
defined in the same module as the leafref data nodes. See section 6.8 in RFC
7951. Therefore, it is necessary to either replace all 75 occurences of the
"ietf-nss" prefix in Appendix B with "ietf-network-slice-service", or remove
the prefixes altogether.

**** Nits

- Names of several lists are somewhat confusing. For example, list "tag-type"
has two children: "tag-type" (key) and "value". It would IMO be better to call
the outer list e.g. "tag-type-value". - Upcoming RFCs with placeholder numbers
BBBB, CCCC and DDDD that are used in reference statements should also appear in
sec. 11.1 (Normative References).