Skip to main content

Last Call Review of draft-ietf-tokbind-negotiation-10
review-ietf-tokbind-negotiation-10-opsdir-lc-liu-2017-12-04-00

Request Review of draft-ietf-tokbind-negotiation
Requested revision No specific revision (document currently at 14)
Type Last Call Review
Team Ops Directorate (opsdir)
Deadline 2017-11-27
Requested 2017-11-13
Authors Andrei Popov , Magnus Nyström , Dirk Balfanz , Adam Langley
I-D last updated 2017-12-04
Completed reviews Genart Last Call review of -10 by Paul Kyzivat (diff)
Secdir Last Call review of -10 by Hilarie Orman (diff)
Opsdir Last Call review of -10 by Will (Shucheng) LIU (diff)
Artart Telechat review of -12 by Matthew A. Miller (diff)
Genart Telechat review of -12 by Paul Kyzivat (diff)
Assignment Reviewer Will (Shucheng) LIU
State Completed
Request Last Call review on draft-ietf-tokbind-negotiation by Ops Directorate Assigned
Reviewed revision 10 (document currently at 14)
Result Ready
Completed 2017-12-04
review-ietf-tokbind-negotiation-10-opsdir-lc-liu-2017-12-04-00
I have reviewed draft-ietf-tokbind-negotiation-10 as part of the Operational
directorate's ongoing effort to review all IETF documents being processed by
the IESG.  These comments were written with the intent of improving the
operational aspects of the IETF drafts. Comments that are not addressed in last
call may be included in AD reviews during the IESG review.  Document editors
and WG chairs should treat these comments just like any other last call
comments.

“ This document specifies a Transport Layer Security (TLS) extension for the
negotiation of Token Binding protocol version and key
   parameters.”

My overall view of the document is 'Ready with Nits' for publication.

Section 3
>   "token_binding_version" contains the lower of:
>  o  the Token Binding protocol version offered by the client in the
>      "token_binding" extension and
>   o  the highest version supported by the server.

"The highest version" means  the highest *Token Binding protocol* version? If
yes, please indicate directly to eliminate confusion.

Section 8
>   [I-D.ietf-tokbind-protocol]
>             Popov, A., Nystrom, M., Balfanz, D., Langley, A., and J.
>             Hodges, "The Token Binding Protocol Version 1.0", draft-
>             ietf-tokbind-protocol-15 (work in progress), July 2017.

A later version (-16) should be put here.