Telechat Review of draft-ietf-trill-transport-over-mpls-07
review-ietf-trill-transport-over-mpls-07-genart-telechat-bryant-2018-03-02-00

Request Review of draft-ietf-trill-transport-over-mpls
Requested revision No specific revision (document currently at 08)
Type Telechat Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2018-03-06
Requested 2018-02-19
Authors Mohammed Umair , Kingston Smiler , Donald E. Eastlake 3rd , Lucy Yong
I-D last updated 2018-03-02
Completed reviews Rtgdir Early review of -02 by Matthew Bocci (diff)
Secdir Telechat review of -07 by Derek Atkins (diff)
Genart Telechat review of -07 by Stewart Bryant (diff)
Assignment Reviewer Stewart Bryant
State Completed
Request Telechat review on draft-ietf-trill-transport-over-mpls by General Area Review Team (Gen-ART) Assigned
Reviewed revision 07 (document currently at 08)
Result Ready w/issues
Completed 2018-03-02
review-ietf-trill-transport-over-mpls-07-genart-telechat-bryant-2018-03-02-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please wait for direction from your
document shepherd or AD before posting a new version of the draft.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-trill-transport-over-mpls-07
Reviewer: Stewart Bryant
Review Date: 2018-03-02
IETF LC End Date: 2018-03-06
IESG Telechat date: 2018-03-08

Summary: An understandable document. The only comment of note is the conflation
of PW headers and MPLS headers. There are a couple of easy to fix nits.

Major issues: None

Minor issues:

6. Packet Processing Between Pseudowires

 In this section you conflate PW headers and MPLS headers.
The PW label is a type of  MPLS label, although it has its own forwarding
instruction, but the control word is not part of MPLS.

Nits/editorial comments:

There is an ASCII art error in Fig 1 on the line containing Tenant1 Site1

The terms PE device and PE router seem to be used interchangeably.  Is this an
error, or are they distinct devices.

The VTSD must be capable of forming TRILL adjacency with the
SB> Should be "forming a TRILL adjacency"