Skip to main content

Telechat Review of draft-ietf-tsvwg-rfc6040update-shim-20
review-ietf-tsvwg-rfc6040update-shim-20-intdir-telechat-eastlake-2023-11-22-00

Request Review of draft-ietf-tsvwg-rfc6040update-shim
Requested revision No specific revision (document currently at 23)
Type Telechat Review
Team Internet Area Directorate (intdir)
Deadline 2023-11-23
Requested 2023-11-14
Requested by Éric Vyncke
Authors Bob Briscoe
I-D last updated 2023-11-22
Completed reviews Intdir Telechat review of -20 by Donald E. Eastlake 3rd (diff)
Assignment Reviewer Donald E. Eastlake 3rd
State Completed
Request Telechat review on draft-ietf-tsvwg-rfc6040update-shim by Internet Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/int-dir/7SKAK_9HFqAmGG_FQz4v8_yQClM
Reviewed revision 20 (document currently at 23)
Result Ready w/nits
Completed 2023-11-22
review-ietf-tsvwg-rfc6040update-shim-20-intdir-telechat-eastlake-2023-11-22-00
I am an assigned INT directorate reviewer for
<draft-ietf-tsvwg-rfc6040update-shim-20.txt>. These comments were written
primarily for the benefit of the Internet Area Directors. Document editors
and shepherd(s) should treat these comments just like they would treat
comments from any other IETF contributors and resolve them along with any
other Last Call comments that have been received. For more details on the
INT Directorate, see https://datatracker.ietf.org/group/intdir/about/ <
https://datatracker.ietf.org/group/intdir/about/>.

Based on my review, if I was on the IESG I would ballot this document as
YES.

This is a well written document that updates RFC 6040 and a number of other
RFCs to specify/clarify the propagation of Explicit Congestion
Notification (ECN) between inner and outer headers when separated by a shim

The following are minor issues (typos, misspelling, minor text
improvements) with the document:

- The usual way to indicate values to be assigned by IANA is to say "TBD"
(or, if there are multiple, TBD1, TBD2, etc.) I think that is what ZZ is
supposed to be so I suggest globally replacing "ZZ" with "TBD" and
eliminating the phrase in curly brackets in the first sentence of
6.1.1.2.1.  IANA and the RFC Editor know about TBDs and to replace them.

- The usual way to indicate a reference to the document containing that
reference is "[this document]". Suggest globally replacing "RFCXXXX" with
"[this document]" and eliminating the often repeated direction in curly
brackets to the RFC Editor to replace "RFCXXXX" with the document. The RFC
Editor knows about "[this document]" and to replace it.

- Although many RFC references are square bracket references, there are
many cases that just have "RFC" followed by a space and the number. Suggest
a global search for RFC followed by a space (or new line) and replace with
a square bracket reference.

- Suggest spelling out 3GPP on first use and/or providing a reference.
Thanks,
Donald
===============================
 Donald E. Eastlake 3rd   +1-508-333-2270 (cell)
 2386 Panoramic Circle, Apopka, FL 32703 USA
 d3e3e3@gmail.com