Skip to main content

Early Review of draft-ietf-tvr-schedule-yang-05
review-ietf-tvr-schedule-yang-05-secdir-early-yee-2025-10-31-00

Request Review of draft-ietf-tvr-schedule-yang
Requested revision No specific revision (document currently at 07)
Type Early Review
Team Security Area Directorate (secdir)
Deadline 2025-11-01
Requested 2025-10-16
Requested by Tony Li
Authors Yingzhen Qu , Acee Lindem , Eric Kinzie , Don Fedyk , Marc Blanchet
I-D last updated 2026-01-19 (Latest revision 2026-01-19)
Completed reviews Yangdoctors Early review of -03 by Xufeng Liu (diff)
Rtgdir Early review of -05 by Susan Hares (diff)
Secdir Early review of -05 by Peter E. Yee (diff)
Opsdir Early review of -05 by Chongfeng Xie (diff)
Comments
Please review. We believe that this is ready for WGLC. Thanks!
Assignment Reviewer Peter E. Yee
State Completed
Request Early review on draft-ietf-tvr-schedule-yang by Security Area Directorate Assigned
Posted at https://mailarchive.ietf.org/arch/msg/secdir/NUEaOQKsdmkcG-s2aZ72r67Pzt0
Reviewed revision 05 (document currently at 07)
Result Has nits
Completed 2025-10-31
review-ietf-tvr-schedule-yang-05-secdir-early-yee-2025-10-31-00
This is a YANG model that specifies modules for network elements that have
periods of scheduled availability and/or unavailability. From a security
perspective, it all seems fine, particularly with its inheritance of the
underlying NETCONF or RESTCONF for primary in-flight data protection. It does
point out some concerns about specific elements of the modules. I found a few
nits while reading the document that are detailed below, but I did not really
attempt to validate that the YANG modules are fit for purpose, nor did I
comprehensively look for nits. Nit finding is just something I do to lighten
the load on the RFC Editor.

Nits:

Page 8, section 5, 1st sentence: change "RFCs" to "RFC". Change both
occurrences of "are" to "is". Page 23, 1st sentence: change "start" to
"starting".

Page 15, description for "ietf-tvr-topology", 1st paragraph, 1st sentence:
change "an" to "a".

Page 16, description for "node-id" (from previous page): change the comma to a
semicolon.

Page 16, description for "available" (at bottom of page): delete an extra white
space after "link".

Page 17, description for "default-link-available", 1st sentence (near bottom of
page): change "availibility" to "availability".

Page 17, description for "default-link-available", 2nd sentence: change
"specifiy" to "specify".

Page 19, at the top, add a line break after
"/topology-schedule/links/available".

Page 23, 2nd sentence: delete the commas that bracket "eth 1".

Page 25, 1st paragraph, 1st sentence: delete the comma after "node:1".

Page 25, 2nd paragraph, 1st sentence: delete the commas that bracket "node:2".
Change "starts" to "starting". Change "lasts" to "lasting".