EdDSA Value for IPSECKEY
draft-moskowitz-ipsecme-ipseckey-eddsa-09

[Ballot comment]
One minor issue. The entry for 0 states:

0 No key is present

Since all entries were fixed from "key" to "public key", perhaps this one should say "No Public Key present" ?

[Ballot comment]
Hi,

I assume that this is just an oversight from another change, or otherwise section 3.1.1 is unclear to me: The request to IANA is to add a "Format Specification" column, but the table includes a "Format description" column instead.  My assumption is that these are meant to be the same thing.

Regards,
Rob

[Ballot comment]
# GEN AD review of draft-moskowitz-ipsecme-ipseckey-eddsa-06

CC @larseggert

Thanks to Behcet Sarikaya for the General Area Review Team (Gen-ART) review
(https://mailarchive.ietf.org/arch/msg/gen-art/FpxM6xz7RQ2fi3hmPYZG3jcFtuw).

## Nits

All comments below are about very minor potential issues that you may choose to
address in some way - or ignore - as you see fit. Some were flagged by
automated tools (via https://github.com/larseggert/ietf-reviewtool), so there
will likely be some false positives. There is no need to let me know what you
did with these suggestions.

### URLs

These URLs in the document can probably be converted to HTTPS:

* http://www.sandelman.ca/

### Grammar/style

#### "Table of Contents", paragraph 1
```
ormats for the public keys. This documents adds support for Edwards-Curve Di
                                ^^^^^^^^^
```
Consider using the singular form after the singular determiner "This".

## Notes

This review is in the ["IETF Comments" Markdown format][ICMF], You can use the
[`ietf-comments` tool][ICT] to automatically convert this review into
individual GitHub issues. Review generated by the [`ietf-reviewtool`][IRT].

[ICMF]: https://github.com/mnot/ietf-comments/blob/main/format.md
[ICT]: https://github.com/mnot/ietf-comments
[IRT]: https://github.com/larseggert/ietf-reviewtool

(Via drafts-lastcall@iana.org): IESG/Authors/WG Chairs:

The IANA Functions Operator has completed its review of draft-moskowitz-ipsecme-ipseckey-eddsa-06. If any part of this review is inaccurate, please let us know.

The IANA Functions Operator understands that, upon approval of this document, there are two actions which we must complete.

First, in the Algorithm Type Field registry on the IPSECKEY Resource Record Parameters registry page located at:

https://www.iana.org/assignments/ipseckey-rr-parameters/

IANA will add a new field "Format Specification" to the "Algorithm Type Field" subregistry of the registry. IANA will update the "Description" field in existing entries of that registry to explicitly state that is for "Public" keys:

Value Description Format specification Reference
0 No key is present [RFC4025]
1 A DSA Public Key [RFC2536], Sec. 2 [RFC4025]
2 A RSA Public Key [RFC3110], Sec. 2 [RFC4025]
3 An ECDSA Public Key [RFC6605], Sec. 4 [RFC8005]


IANA will update the reference of that registry by adding the RFC number to be assigned to this document.

Second, also in the Algorithm Type Field registry on the IPSECKEY Resource Record Parameters registry page located at:

https://www.iana.org/assignments/ipseckey-rr-parameters/

a single, new registration is to be made as follows:

Value: [ TBD-at-Registration ]
Description: An EdDSA Public Key
Format description: [ RFC8080, Section 3 ]
Reference: [ RFC-to-be ]

The IANA Functions Operator understands that these two actions are the only ones required to be completed upon approval of this document.

Note:  The actions requested in this document will not be completed until the document has been approved for publication as an RFC. This message is meant only to confirm the list of actions that will be performed.

For definitions of IANA review states, please see:

https://datatracker.ietf.org/help/state/draft/iana-review

Thank you,

David Dong
IANA Services Specialist

The following Last Call announcement was sent out (ends 2022-12-12):

From: The IESG
To: IETF-Announce
CC: draft-moskowitz-ipsecme-ipseckey-eddsa@ietf.org, rdd@cert.org
Reply-To: last-call@ietf.org
Sender:
Subject: Last Call:  (EdDSA value for IPSECKEY) to Proposed Standard


The IESG has received a request from an individual submitter to consider the
following document: - 'EdDSA value for IPSECKEY'
  as Proposed Standard

The IESG plans to make a decision in the next few weeks, and solicits final
comments on this action. Please send substantive comments to the
last-call@ietf.org mailing lists by 2022-12-12. Exceptionally, comments may
be sent to iesg@ietf.org instead. In either case, please retain the beginning
of the Subject line to allow automated sorting.

Abstract


  This document assigns a value for EdDSA Public Keys to the IPSECKEY
  IANA registry.




The file can be obtained via
https://datatracker.ietf.org/doc/draft-moskowitz-ipsecme-ipseckey-eddsa/



No IPR declarations have been submitted directly on this I-D.