Skip to main content

Early Review of draft-ietf-bess-mvpn-msdp-sa-interoperation-00
review-ietf-bess-mvpn-msdp-sa-interoperation-00-rtgdir-early-jia-2018-04-17-00

Request Review of draft-ietf-bess-mvpn-msdp-sa-interoperation-00
Requested revision 00 (document currently at 08)
Type Early Review
Team Routing Area Directorate (rtgdir)
Deadline 2018-04-16
Requested 2018-03-28
Requested by Stephane Litkowski
Authors Zhaohui (Jeffrey) Zhang , Lenny Giuliano
I-D last updated 2018-04-17
Completed reviews Rtgdir Early review of -00 by He Jia (diff)
Rtgdir Early review of -05 by He Jia (diff)
Opsdir Last Call review of -05 by Qin Wu (diff)
Comments
We would like to evaluate the readability/understandability of the document  as well as its technical content.
Assignment Reviewer He Jia
State Completed
Request Early review on draft-ietf-bess-mvpn-msdp-sa-interoperation by Routing Area Directorate Assigned
Reviewed revision 00 (document currently at 08)
Result Has issues
Completed 2018-04-17
review-ietf-bess-mvpn-msdp-sa-interoperation-00-rtgdir-early-jia-2018-04-17-00
Hello,

I have been selected to do a routing directorate “early” review of this draft.
https://datatracker.ietf.org/doc/draft-ietf-bess-mvpn-msdp-sa-interoperation/

The routing directorate will, on request from the working group chair, perform
an “early” review of a draft before it is submitted for publication to the
IESG. The early review can be performed at any time during the draft’s lifetime
as a working group document. The purpose of the early review depends on the
stage that the document has reached.

As this document has recently been adopted by the working group, my focus for
the review is on providing a new perspective on the work, with the intention of
catching any issues early on in the document's life cycle.

For more information about the Routing Directorate, please see
​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir

Document draft-ietf-bess-mvpn-msdp-sa-interoperation-00.txt
Reviewer: Jia He
Review Date: 16 April 2018
Intended Status: Standards Track

Summary
The document clearly describes the problem and specifies the MVPN/MSDP SA
interoperation procedures. However, I have a minor concern that I think should
be resolved before it is submitted to the IESG.

Comments
The current version of the draft lacks security considerations. Since the work
in this draft is about interoperation between MVPN and MSDP, security
considerations are need IMHO.

Nits:
1) Section 2, "...but [RFC6514] does not specify that it advertise MSDP SA
messages to those MSDP peers... " , s/advertise/advertises 2) Section 2, "While
MSDP Source Active routes contain the source, group and RP address of a given
multicast flow,....", s/address/addresses

B.R.
Jia