Skip to main content

Last Call Review of draft-ietf-bfd-large-packets-13
review-ietf-bfd-large-packets-13-genart-lc-romascanu-2024-12-06-01

Request Review of draft-ietf-bfd-large-packets
Requested revision No specific revision (document currently at 16)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2024-12-09
Requested 2024-11-25
Authors Jeffrey Haas , Albert Fu
I-D last updated 2024-12-06
Completed reviews Yangdoctors Last Call review of -07 by Jürgen Schönwälder (diff)
Secdir Early review of -11 by Joseph A. Salowey (diff)
Genart Last Call review of -13 by Dan Romascanu (diff)
Secdir Last Call review of -14 by Joseph A. Salowey (diff)
Tsvart Last Call review of -14 by Brian Trammell (diff)
Assignment Reviewer Dan Romascanu
State Completed
Request Last Call review on draft-ietf-bfd-large-packets by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/TJZ0UHaHT7XjnnzgTqCRLPjGltg
Reviewed revision 13 (document currently at 16)
Result Ready w/issues
Completed 2024-12-06
review-ietf-bfd-large-packets-13-genart-lc-romascanu-2024-12-06-01
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-bfd-large-packets-13
Reviewer: Dan Romascanu
Review Date: 2024-12-06
IETF LC End Date: 2024-12-09
IESG Telechat date: Not scheduled for a telechat

Summary:

Ready with Issues

This document extends the BFD functionality for checking connectivity between
two systems with testing the capability of carrying a payloads of a particular
size. It specifies how to implement such a mechanism using BFD in Asynchronous
mode.It also includes YANG modules for managing this mechanism.

This is a clear, well-written document. It is almost Ready with one minor issue
(which may be just a clarification issue) and a couple of editorial nits.

Major issues:

Minor issues:

1. Section 4.2

'In the case multiple BFD clients desire to test the same BFD
   endpoints using different bfd.PaddedPduSize parameters,
   implementations SHOULD select the largest bfd.PaddedPduSize parameter
   from the configured sessions. '

Why a SHOULD and not a MUST?

Nits/editorial comments:

1. Section 4.2

'Since the consideration is path MTU, BFD sessions using this feature
   only need to use a bfd.PaddedPduSize appropriate to exercise the path
   MTU for the desired application.

This sentence seems to need some syntax clean-up.

2. I am not sure about Appendix A. If this is useful information, why not
include it in the body of the document. If not, eliminate it.