IETF Last Call Review of draft-ietf-bfd-secure-sequence-numbers-24
review-ietf-bfd-secure-sequence-numbers-24-yangdoctors-lc-lindem-2025-08-30-00

Request Review of draft-ietf-bfd-secure-sequence-numbers
Requested revision No specific revision (document currently at 27)
Type IETF Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2025-08-29
Requested 2025-08-19
Requested by Ketan Talaulikar
Authors Alan DeKok , Mahesh Jethanandani , Sonal Agarwal , Ashesh Mishra , Jeffrey Haas
I-D last updated 2026-06-19 (Latest revision 2025-10-16)
Completed reviews Secdir Early review of -18 by Rich Salz (diff)
Rtgdir IETF Last Call review of -18 by Ben Niven-Jenkins (diff)
Opsdir Early review of -18 by Yingzhen Qu (diff)
Genart IETF Last Call review of -22 by Mallory Knodel (diff)
Yangdoctors IETF Last Call review of -24 by Acee Lindem (diff)
Comments 
The YANG module of this document was reviewed previously by YANG doctors (Qiufang Ma - https://datatracker.ietf.org/doc/review-ietf-bfd-optimizing-authentication-18-yangdoctors-early-ma-2024-08-01/) when it was part of that document. The module was later moved to this document with very minor changes.

Requesting this review just to ensure that we are still all good.

Prefer Qiufang Ma as reviewer (if available) given the past context.
Assignment Reviewer Acee Lindem
State Completed
Request IETF Last Call review on draft-ietf-bfd-secure-sequence-numbers by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/u4wTh8fW2UhQoxuC461Rf4MRUHI/
Reviewed revision 24 (document currently at 27)
Result Not ready
Completed 2025-08-30
review-ietf-bfd-secure-sequence-numbers-24-yangdoctors-lc-lindem-2025-08-30-00
Document: draft-ietf-bfd-secure-sequence-numbers-24.txt
Reviewer: Acee Lindem
Review Date: 08/29/2025
IETF LC End Date: N/A
Intended Status: Experimental

Result: Not Ready (although it should be very easy to fix)

This is YANG doctor review on the YANG model ietf-bfd-met-keyed-isaac.yang.

The following issues have to be addressed:

   1. The first use of the acronym ISAAC should be expanded in the YANG data
        module (and also the draft).
   2. The prefix should be "bfdmki" for "BFD Meticulously Keyed ISAAC" rather than
      "bfdmia" for "BFD Missing In Action". I guess this refers to the selection of the
       YANG data module prefix? 
   3. The identities optimized-md5-meticulous-keyed-isaac and
      optimized-md5-meticulous-keyed-isaac must be removed from
      ietf-bfd-opt-auth.yang as they are now in this YANG data module.
   4. The "Security Considerations" section of the draft is missing the
      YANG boilerplate for the YANG model described in the draft.

Consider:

   1. Should each optimized authentication method have its own YANG feature rather
      than a single one for "optimized-auth? If not, maybe keep a single YANG model
      ietf-bfd-opt-auth.yang with a reference to this draft (as long as both drafts progress
      together). 


Thanks,
Acee