Last Call Review of draft-ietf-ccamp-flexe-yang-cm-02
review-ietf-ccamp-flexe-yang-cm-02-yangdoctors-lc-lhotka-2023-08-14-00

Request Review of draft-ietf-ccamp-flexe-yang-cm
Requested revision No specific revision (document currently at 04)
Type Last Call Review
Team YANG Doctors (yangdoctors)
Deadline 2023-08-14
Requested 2023-07-14
Requested by Daniele Ceccarelli
Authors Minxue Wang , Liuyan Han , Xuesong Geng , Jin Zhou , Luis M. Contreras , Xufeng Liu
I-D last updated 2023-08-14
Completed reviews Yangdoctors Last Call review of -02 by Ladislav Lhotka (diff)
Rtgdir Last Call review of -02 by Shuping Peng (diff)
Assignment Reviewer Ladislav Lhotka
State Completed
Request Last Call review on draft-ietf-ccamp-flexe-yang-cm by YANG Doctors Assigned
Posted at https://mailarchive.ietf.org/arch/msg/yang-doctors/6JmZ5g7uT-46FNsDu5Xx5l_WRe8
Reviewed revision 02 (document currently at 04)
Result Ready w/issues
Completed 2023-08-14
review-ietf-ccamp-flexe-yang-cm-02-yangdoctors-lc-lhotka-2023-08-14-00
**** General comments

The ietf-flexe module is a relative small YANG module based on an
implementation agreed upon by the OIF Forum. From the YANG point of view, the
only problem of the module that I found is that all configuration leaves in the
"flexe-client" container are mandatory, which eventually makes the top-level
container "ietf-flexe:flexe" mandatory. This violates the requirement in sec.
4.10 of RFC 8407: Top-level data node MUST NOT be mandatory.

**** Specific comments

***** Section 2
- The list of requirements would be better formatted as a definition list
(<dl>) of xml2rfc v3. - A spurious character entity representing Unicode
character U+12289 appears at the end of the requirement R-Group-02.

***** Appendices
- It would be useful to indicate (at least schematically) that <port-num>
leaves are references (leafrefs) to interfaces defined using the
ietf-interfaces module.