Last Call Review of draft-ietf-ccamp-flexe-yang-cm-02
review-ietf-ccamp-flexe-yang-cm-02-rtgdir-lc-peng-2023-07-25-00
Request | Review of | draft-ietf-ccamp-flexe-yang-cm |
---|---|---|
Requested revision | No specific revision (document currently at 05) | |
Type | Last Call Review | |
Team | Routing Area Directorate (rtgdir) | |
Deadline | 2023-08-14 | |
Requested | 2023-07-14 | |
Requested by | Daniele Ceccarelli | |
Authors | Minxue Wang , Liuyan Han , Xuesong Geng , Jin Zhou , Luis M. Contreras , Xufeng Liu | |
I-D last updated | 2023-07-25 | |
Completed reviews |
Yangdoctors Last Call review of -02
by Ladislav Lhotka
(diff)
Rtgdir Last Call review of -02 by Shuping Peng (diff) |
|
Assignment | Reviewer | Shuping Peng |
State | Completed | |
Request | Last Call review on draft-ietf-ccamp-flexe-yang-cm by Routing Area Directorate Assigned | |
Posted at | https://mailarchive.ietf.org/arch/msg/rtg-dir/lIAX3o-eSmxJCEkhMfYMzWoRoO0 | |
Reviewed revision | 02 (document currently at 05) | |
Result | Has nits | |
Completed | 2023-07-25 |
review-ietf-ccamp-flexe-yang-cm-02-rtgdir-lc-peng-2023-07-25-00
Hello, I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft. Document: draft-ietf-ccamp-flexe-yang-cm-02 Reviewer: Shuping Peng Review Date: 26 July 2023 IETF LC End Date: - Intended Status: Standards Summary: This document is basically ready for publication but has nits that should be considered prior to publication. Comments: 1. Introduction "Cross connection of FlexE timeslots in a network node is tentatively out of the scope of this document." Should the word "tentatively" be deleted? Major Issues: No major issues found. Minor Issues: No minor issues found. Nits: 1. Introduction The YANG modules in this document s/conforms/conform to 1.2 Terminology The terminology for describing YANG data models s/is/can be 2. Requirements of FlexE configuration s/In following sections/In this section s/FlexE YANG data model targets to provide the configurations of the functions, as well as to report the real states and verify the consistency between the configuration and the real states. /FlexE YANG data model aims to provide the configurations of functions, report real states, and verify the consistency between the configurations and real states. s/SHOULD be invoked.、/SHOULD be invoked. 5. Security Considerations s/an inappropriate configuration of them may cause an interrupt of a FlexE client flow, drop of all Ethernet frames of a FlexE client, or even break down of a whole FlexE group interface. /an inappropriate configuration may interrupt a FlexE client flow, drop all Ethernet frames of a FlexE client, or even break down a whole FlexE group interface. 6. IANA Considerations s/be registred/be registered