Skip to main content

Last Call Review of draft-ietf-core-oscore-edhoc-09
review-ietf-core-oscore-edhoc-09-artart-lc-peng-2023-11-14-00

Request Review of draft-ietf-core-oscore-edhoc
Requested revision No specific revision (document currently at 11)
Type Last Call Review
Team ART Area Review Team (artart)
Deadline 2023-11-13
Requested 2023-10-23
Authors Francesca Palombini , Marco Tiloca , Rikard Höglund , Stefan Hristozov , Göran Selander
I-D last updated 2023-11-14
Completed reviews Opsdir Telechat review of -10 by Jürgen Schönwälder (diff)
Secdir Telechat review of -10 by Wes Hardaker (diff)
Artart Telechat review of -10 by Shuping Peng (diff)
Iotdir Telechat review of -10 by Emmanuel Baccelli (diff)
Artart Last Call review of -09 by Shuping Peng (diff)
Opsdir Last Call review of -09 by Jürgen Schönwälder (diff)
Secdir Last Call review of -09 by Wes Hardaker (diff)
Genart Last Call review of -09 by Joel M. Halpern (diff)
Assignment Reviewer Shuping Peng
State Completed
Request Last Call review on draft-ietf-core-oscore-edhoc by ART Area Review Team Assigned
Posted at https://mailarchive.ietf.org/arch/msg/art/7hHGzufDCFCmbNL6JvP_9Ad0cyE
Reviewed revision 09 (document currently at 11)
Result Ready w/issues
Completed 2023-11-14
review-ietf-core-oscore-edhoc-09-artart-lc-peng-2023-11-14-00
I am the assigned ART-ART reviewer for this draft.

Summary:
I have some minor concerns about this document that I think should be resolved
before publication.

Comments:
I think this document is basically ready for publication.

Major Issues:
"No major issues found."

Minor Issues:
Where the "C_R" is actually carried is not clear. It would be good if the
following text in Section 3 could be more clear about it, and it might also be
helpful to show the "C_R" in Figure 2. "     EDHOC data consisting of the pair
(C_R, EDHOC message_3) required
      for completing the EDHOC session.  Note that, as specified in
      Section 3.2, C_R is transported in the OSCORE Option of the OSCORE
      Request rather than in the CoAP payload of the EDHOC + OSCORE
      request.
"