Skip to main content

Last Call Review of draft-ietf-detnet-data-plane-framework-04
review-ietf-detnet-data-plane-framework-04-genart-lc-holmberg-2020-03-15-00

Request Review of draft-ietf-detnet-data-plane-framework
Requested revision No specific revision (document currently at 06)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2020-03-13
Requested 2020-02-28
Authors Balazs Varga , János Farkas , Lou Berger , Andrew G. Malis , Stewart Bryant
Draft last updated 2020-03-15
Completed reviews Rtgdir Last Call review of -03 by Sasha Vainshtein (diff)
Tsvart Last Call review of -04 by Yoshifumi Nishida (diff)
Genart Last Call review of -04 by Christer Holmberg (diff)
Secdir Last Call review of -04 by Chris M. Lonvick (diff)
Assignment Reviewer Christer Holmberg
State Completed
Review review-ietf-detnet-data-plane-framework-04-genart-lc-holmberg-2020-03-15
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/PxMlDVkUIg3KNQRSaKzyboSf6TI
Reviewed revision 04 (document currently at 06)
Result Ready with Nits
Completed 2020-03-15
review-ietf-detnet-data-plane-framework-04-genart-lc-holmberg-2020-03-15-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://trac.ietf.org/trac/gen/wiki/GenArtfaq>.

Document: draft-ietf-detnet-data-plane-framework-04
Reviewer: Christer Holmberg
Review Date: 2020-03-15
IETF LC End Date: 2020-03-13
IESG Telechat date: Not scheduled for a telechat

Summary: The document is well written, and almost ready for publication. I have
no issues on the technical parts, but I have found some editorial nits in the
Introduction- and Security Considerations sections that I ask the authors to
address.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:

Q1:

The first line of the Introduction says:

“DetNet (Deterministic Networking) provides a capability…”

Please add a reference to DetNet/RFC8655 on first occurance.

Q2:

The first line of the 2nd paragraph of the Introduction says:

“This document describes the concepts needed by any DetNet data plane
specification…”

What is meant by DetNet data plane specification? The definition of DetNet
flows over a specific network technology? Please clarify, or reference if
already defined elsewhere.

Q3:

The 5th paragraph of the Introduction (“DetNet flows may be carried over
network…”) contains text about network topologies that can be used for DetNet
flows.

Is the text (all, or part of it) in the paragraph somehow specific to this
document, or is it simply repeating things that are defined in RFC 8655? If the
paragraph is only repeating stuff, maybe start with “As defined in RFC8655,
DetNet flows may be carried…”.

Q4:

The 6th paragraph of the Introduction says:

“Different application flows (e.g., Ethernet, IP, etc.)…”

The text may it look like the Ethernet, IP etc is the actual application flow.
I assume you mean application flow carried over Ethernet, IP, etc? If so,
please modify to make it more clear.

Q5:

The Security considerations say:

“Security considerations for DetNet are described in detail in
[I-D.ietf-detnet-security].  General security considerations are
described in [RFC8655].”

The sentence is confusing. General security considerations for what? Doesn’t
RFC 8655 also describe security considerations for DetNet?